Repository navigation
docs: mention missing animations in KeyboardStickyView/KeyboardToolbar and the recommended fix - #1624
Merged
Merged
Conversation
…lbar` and the recommended fix
Contributor
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Contributor
|
LGTM |
|
@kirillzyusko Does this cause the animation to not happen at all? Like it would apply 0 padding so the keyboard is actually not pushed upwards? |
Owner
Author
|
@sommeeeer no, the animation will be just instant in this case, i. e. it will shift content by |
|
Alright :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Recommend to enable
DISABLE_COMMIT_PAUSING_MECHANISMfeature flag in reanimated.💡 Motivation and Context
KeyboardStickyViewhas been migrated to reanimated recently.At the moment reanimated has a bug, when animation can be canceleld because react will perform another commit.
In this PR I recommend to enable specific feature flags to avoid this probelm. We recommended to turn this flag on for
KeyboardAvoidingViewand forKeyboardChatScrollView.📢 Changelog
Docs
DISABLE_COMMIT_PAUSING_MECHANISMif you are usingKeyboardStickyView/KeyboardToolbar+ new arch.🤔 How Has This Been Tested?
Tested via deployed version.
📸 Screenshots (if appropriate):
📝 Checklist