Repository navigation
fix: support NestedScrollView in KeyboardAwareScrollView - #1639
Merged
kirillzyusko merged 1 commit intoSep 11, 2026
Merged
Conversation
Contributor
📊 Package size report
|
kirillzyusko
marked this pull request as ready for review
September 11, 2026 08:15
Contributor
|
kirillzyusko
deleted the
fix/support-nested-scroll-view-in-aware-scroll-view
branch
September 11, 2026 08:27
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added support for
NestedScrollViewforKeyboardAwareScrollView.💡 Motivation and Context
When users enable
useNestedScrollViewAndroidfeature flag, thenReactNestedScrollViewis used:As a result our condition returns
false(casting ofparentViewtoReactScrollViewis failing):So we never recognize the
ReactNestedScrollViewas aScrollViewand because of that condition is evaluated astrue:So scrolling never works.
In this PR I created small extension called
View.isEnabledReactScrollView()that checks both cases:ReactScrollViewandReactNestedScrollView.This implementation had technical difficulties, because
ReactNestedScrollViewis not available in earlier RN versions (was introduced only in RN 0.85+) so I had to use reflection, because we can not use direct class references as it may be not available in all framework versions.Closes #1537
📢 Changelog
Android
View.isEnabledReactScrollView()extension that checks bothReactScrollView/ReactNestedScrollViewcases;isEnabledReactScrollView()condition instead of previous check;🤔 How Has This Been Tested?
Tested via CI (e2e tests).
📸 Screenshots (if appropriate):
📝 Checklist