Preserve backend ports and host rewrites in endpoint probes - #1301
Open
kahirokunn wants to merge 1 commit into
Open
Preserve backend ports and host rewrites in endpoint probes#1301kahirokunn wants to merge 1 commit into
kahirokunn wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 93.41% 93.74% +0.32%
==========================================
Files 9 9
Lines 653 687 +34
==========================================
+ Hits 610 644 +34
Misses 22 22
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kahirokunn
force-pushed
the
fix-previous-endpoint-probe-host-rewrite
branch
from
August 31, 2026 17:54
f39fb14 to
b00081f
Compare
kahirokunn
marked this pull request as draft
August 31, 2026 18:03
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
force-pushed
the
fix-previous-endpoint-probe-host-rewrite
branch
from
September 1, 2026 04:59
b00081f to
231a047
Compare
kahirokunn
marked this pull request as ready for review
September 1, 2026 05:00
Member
Author
|
@linkvt Hi ✋ Could you please review this PR when you have time, if you don't mind? Thank you🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Before switching a KIngress to new Envoy programming, net-contour creates a temporary
--epKIngress that keeps the current and previous backends available while Envoy loads the new endpoint configuration.For example, an update can replace this previously programmed HTTPProxy route:
with this KIngress backend:
The endpoint probe grouped backends only by Service name, so
app:8080replacedapp:80in the temporary route. When a previous Service was restored, its route-levelHostrewrite was also lost. The probe could therefore omit the previous Envoy cluster or forward its synthetic*.net-contour.invalidhost to a backend that requires the internal host, leaving the KIngress inEndpointsNotReady.The Host rewrite case is exercised by knative/serving#16685, which changes a DomainMapping KIngress from a cluster-local Service backend to direct Revision Service backends.
Changes
Key endpoint-probe backends by Service name and port, include the port in each synthetic probe host, and restore the previous HTTPProxy route's
Hostrewrite.Testing
Unit tests cover changed numeric ports, named ports, current-setting precedence for an unchanged backend, and Host rewrite recovery for previous backends.
/kind bug
Release Note
Docs