Skip to content

Add India and Cinema site variants (+ Cinema Hubs map layer) - #5724

Open
Laksh-star wants to merge 1 commit into
koala73:mainfrom
Laksh-star:feat/india-variant
Open

Add India and Cinema site variants (+ Cinema Hubs map layer)#5724
Laksh-star wants to merge 1 commit into
koala73:mainfrom
Laksh-star:feat/india-variant

Conversation

@Laksh-star

@Laksh-star Laksh-star commented Jul 28, 2026

Copy link
Copy Markdown

Summary

Adds two new site variants built entirely on the existing variant system, plus one new static map layer. No engine rewrites — the variants are configuration (panels, default map layers, metadata, feed maps) and routing, following the same pattern as the shipped tech / finance / commodity variants.

india — South Asia desk. A regional geopolitical cut: curated panel set (Asia/India-forward, Western-region desks dropped), India-first RSS sources (The Hindu, Indian Express, Hindustan Times, NDTV, Economic Times, Livemint, Business Standard, plus Hindi outlets and South-Asian neighbours), India-specific metadata, and a default map camera framed on the subcontinent instead of the global view. Run with npm run dev:india.

cinema — film & entertainment desk (global, India lens). An entertainment-intelligence cut: new panels (Entertainment, Indian Cinema, Box Office, OTT & Streaming, Festivals & Awards), entertainment RSS sources (Variety, THR, Deadline, IndieWire, Screen Daily, Film Companion, Bollywood/regional coverage), and a new "Cinema Hubs" map layer — a deck.gl ScatterplotLayer rendering ~23 film festivals, studios, and production hubs worldwide from bundled static data, colour-coded by kind. Run with npm run dev:cinema.

Both variants register through the standard resolver, add dev:/build: scripts, and update the RSS proxy allowlist (all mirror files) for their new feed domains. npm run typecheck passes.

Type of change

  • New feature
  • New data source / feed
  • New map layer

Affected areas

  • Map / Globe
  • News panels / RSS feeds
  • Config / Settings

Checklist

  • Tested locally on the new india and cinema variants (npm run dev:india / dev:cinema)
  • New RSS feed domains added to the RSS proxy allowlist (shared + scripts/shared JSON mirrors and api/_rss-allowed-domains.js)
  • No API keys or secrets committed
  • TypeScript compiles without errors (npm run typecheck)
  • Tested on tech.worldmonitor.app variant — n/a, changes are additive and don't touch existing variants

Documentation Alignment Checklist

N/A — this PR adds two variants and one static map layer. It introduces no new documented API surface, proto changes, or Redis keys, so the claim-ledger / Audit Council / proto-regeneration items don't apply. Happy to add anything specific a maintainer flags.

Screenshots

(adding: India variant framed on South Asia; Cinema variant with the Cinema Hubs map layer; entertainment panels populated)

Notes for reviewers

Changes are additive and scoped to the two new variants — existing variants are untouched. Happy to split India and Cinema into separate PRs, trim scope, or adjust the feed/hub lists if that's preferred.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the World Monitor Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the trust:caution Brin: contributor trust score caution label Jul 28, 2026
@Laksh-star Laksh-star changed the title Feat/india variant Add India and Cinema site variants (+ Cinema Hubs map layer) Jul 28, 2026
@Laksh-star

Copy link
Copy Markdown
Author

Hi 👋 First-time contributor here. This adds two new site variants on top of the existing variant system — India (a South Asia geopolitical desk) and Cinema (a film/entertainment desk, global with an India lens), the latter including a new "Cinema Hubs" deck.gl map layer built from bundled static data.

Everything is additive and scoped to the new variants — no existing variant is touched — and npm run typecheck passes. I've filled in the checklist above and will add screenshots shortly. Totally happy to split India and Cinema into separate PRs, trim the feed/hub lists, or adjust anything to fit the project's conventions. Thanks for taking a look, and for maintaining such a fun codebase to build on.

@koala73 koala73 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (not ready)

CONFLICTING, and the variant wiring is incomplete vs the current one-binary / SITE_VARIANTS system.

Please rebase and then fill the gaps current main requires for a new variant:

  • SITE_VARIANTS / isSiteVariant (not the old inline string list)
  • WEB_DASHBOARD_VARIANTS + branded dashboard HTML / favicons if you claim india.worldmonitor.app / cinema.worldmonitor.app
  • server VARIANT_FEEDS for both variants
  • RSS allowlist for the India desk hosts actually used (HT, ET, Mint, etc.), not only 7 entertainment domains
  • SITE_VARIANT import in DeckGLMap (the India camera preset references it)
  • tooltip / pick handler for cinema-hubs-layer (pickable: true with no tooltip)

Until those land, this is not approvable as two production variants.

@Laksh-star
Laksh-star force-pushed the feat/india-variant branch 2 times, most recently from d20a5a6 to 4cec929 Compare August 19, 2026 15:41
@Laksh-star

Copy link
Copy Markdown
Author

Thanks for the detailed review — all six points addressed, rebased onto current main as a single commit.

  1. SITE_VARIANTS / isSiteVariant — both variants added to the registry; api/download SUPPORTED_VARIANTS updated to match (desktop-one-binary test passes).
  2. WEB_DASHBOARD_VARIANTS / branded HTML / favicons — I've intentionally not claimed india. / cinema. subdomains in this pass, so no favicon/dashboard-HTML assets are required. Canonicals point at worldmonitor.app, and I added matching VARIANT_OG crawler-stub entries so the deploy-config contract stays green. Happy to add full subdomain branding (favicon sets + WEB_DASHBOARD_VARIANTS) as a follow-up if you'd like these promoted to their own hosts.
  3. Server VARIANT_FEEDS — added for both variants (india reuses the full categories with an India-first regional set; cinema has its own entertainment categories).
  4. RSS allowlist — added the India desk hosts actually used (Hindustan Times, Economic Times, Mint, Business Standard, Moneycontrol, The Print, Scroll, Dawn, etc.) alongside the entertainment domains, across all three mirrors.
  5. SITE_VARIANT in DeckGLMap — import is present; the India camera preset uses it.
  6. cinema-hubs-layer tooltip — added a getTooltip case (name / city / country / kind).

Also updated the two lock-tests that adding a variant is meant to trip (webmcp panel-default snapshots and feed-catalog-drift). Local typecheck + biome + the variant/feed/deploy test suites are green. Happy to keep iterating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trust:caution Brin: contributor trust score caution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants