Add India and Cinema site variants (+ Cinema Hubs map layer) - #5724
Add India and Cinema site variants (+ Cinema Hubs map layer)#5724Laksh-star wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the World Monitor Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi 👋 First-time contributor here. This adds two new site variants on top of the existing variant system — India (a South Asia geopolitical desk) and Cinema (a film/entertainment desk, global with an India lens), the latter including a new "Cinema Hubs" Everything is additive and scoped to the new variants — no existing variant is touched — and |
koala73
left a comment
There was a problem hiding this comment.
Review (not ready)
CONFLICTING, and the variant wiring is incomplete vs the current one-binary / SITE_VARIANTS system.
Please rebase and then fill the gaps current main requires for a new variant:
SITE_VARIANTS/isSiteVariant(not the old inline string list)WEB_DASHBOARD_VARIANTS+ branded dashboard HTML / favicons if you claimindia.worldmonitor.app/cinema.worldmonitor.app- server
VARIANT_FEEDSfor both variants - RSS allowlist for the India desk hosts actually used (HT, ET, Mint, etc.), not only 7 entertainment domains
SITE_VARIANTimport inDeckGLMap(the India camera preset references it)- tooltip / pick handler for
cinema-hubs-layer(pickable: truewith no tooltip)
Until those land, this is not approvable as two production variants.
d20a5a6 to
4cec929
Compare
|
Thanks for the detailed review — all six points addressed, rebased onto current
Also updated the two lock-tests that adding a variant is meant to trip (webmcp panel-default snapshots and feed-catalog-drift). Local |
…ver digests, Cinema Hubs layer)
4cec929 to
b2331c6
Compare
Summary
Adds two new site variants built entirely on the existing variant system, plus one new static map layer. No engine rewrites — the variants are configuration (panels, default map layers, metadata, feed maps) and routing, following the same pattern as the shipped
tech/finance/commodityvariants.india— South Asia desk. A regional geopolitical cut: curated panel set (Asia/India-forward, Western-region desks dropped), India-first RSS sources (The Hindu, Indian Express, Hindustan Times, NDTV, Economic Times, Livemint, Business Standard, plus Hindi outlets and South-Asian neighbours), India-specific metadata, and a default map camera framed on the subcontinent instead of the global view. Run withnpm run dev:india.cinema— film & entertainment desk (global, India lens). An entertainment-intelligence cut: new panels (Entertainment, Indian Cinema, Box Office, OTT & Streaming, Festivals & Awards), entertainment RSS sources (Variety, THR, Deadline, IndieWire, Screen Daily, Film Companion, Bollywood/regional coverage), and a new "Cinema Hubs" map layer — adeck.glScatterplotLayerrendering ~23 film festivals, studios, and production hubs worldwide from bundled static data, colour-coded by kind. Run withnpm run dev:cinema.Both variants register through the standard resolver, add
dev:/build:scripts, and update the RSS proxy allowlist (all mirror files) for their new feed domains.npm run typecheckpasses.Type of change
Affected areas
Checklist
indiaandcinemavariants (npm run dev:india/dev:cinema)api/_rss-allowed-domains.js)npm run typecheck)Documentation Alignment Checklist
N/A — this PR adds two variants and one static map layer. It introduces no new documented API surface, proto changes, or Redis keys, so the claim-ledger / Audit Council / proto-regeneration items don't apply. Happy to add anything specific a maintainer flags.
Screenshots
(adding: India variant framed on South Asia; Cinema variant with the Cinema Hubs map layer; entertainment panels populated)
Notes for reviewers
Changes are additive and scoped to the two new variants — existing variants are untouched. Happy to split India and Cinema into separate PRs, trim scope, or adjust the feed/hub lists if that's preferred.