How to generate different kind of validation annotations for different type of List conditions in graphQL schema?

[siva54]

Hi,
I was trying to generate the schema with a List type and came across some issues. As per the schema we have different use cases for a not-null condition for a list,

In my project, I'm using a couple of cases too such as,
[Int!] - This means that the list can be null but cannot have null objects in the list.
[Int]! - This means that the list cannot be null but can have null objects in the list.
When using codegen to generate POJOs, for types with
[Int!]
[Int]!

In both cases, the field is being annotated with,
@javax.validation.constraints.NotNull

This basically means that the List cannot be null. This is incorrect for the type [Int!] and caused some trouble. As of now, I replaced all the NotNull to instead use a PlaceboValidation annotation of mine that does nothing. How do I overcome this and make sure to ensure that the POJO created works as expected?

[siva54]

Hi, I was trying to generate the schema with a List type and came across some issues. As per the schema we have different use cases for a not-null condition for a list, In my project, I'm using a couple of cases too such as, [Int!] - This means that the list can be null but cannot have null objects in the list. [Int]! - This means that the list cannot be null but can have null objects in the list. When using codegen to generate POJOs, for types with [Int!] [Int]!

In both cases, the field is being annotated with, @javax.validation.constraints.NotNull

This basically means that the List cannot be null. This is incorrect for the type [Int!] and caused some trouble. As of now, I replaced all the NotNull to instead use a PlaceboValidation annotation of mine that does nothing. How do I overcome this and make sure to ensure that the POJO created works as expected?

Hi @kobylynskyi . Any idea on this one?

[kobylynskyi]

This looks like a bug in AnnotationsMapper class.
I will do my best to try looking at it soon, but can't promise anything because of the load at my other job.
Thank you for understanding.

[siva54]

Thank you, @kobylynskyi .

[kobylynskyi]

@siva54 Addressed this issue in #960 and it will be released as part of 5.4.1.

[siva54]

Thank you @kobylynskyi

[kobylynskyi]

Created 5.4.1 release PR: #980
Sorry for addressing it so long.