Skip to content

Commit e205112

Browse files
committed
Improvements and method access fixed
1 parent 87a60bd commit e205112

3 files changed

Lines changed: 15 additions & 9 deletions

File tree

‎build.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ plugins {
1717
}
1818

1919
group 'com.github.jonathanxd'
20-
version '2.0-a'
20+
version '2.0.1'
2121

2222
apply plugin: 'java'
2323
apply plugin: 'kotlin'

‎src/main/kotlin/com/github/jonathanxd/bytecodedisassembler/ClassNodeParser.kt‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ object ClassNodeParser {
3737
fun parse(classNode: ClassNode, appender: Appender, appendFrames: Boolean) {
3838
appender.append("")
3939

40-
appender.append("version: ${Util.parseVersion(classNode.version)}")
41-
appender.append("access: ${Util.parseAccess(Util.CLASS, classNode.access)}")
40+
appender.append("version: ${Util.parseVersion(classNode.version)} (${classNode.version})")
41+
appender.append("access: ${Util.parseAccess(Util.CLASS, classNode.access)} (${classNode.access})")
4242

4343
appender.append("")
4444

@@ -174,7 +174,7 @@ object ClassNodeParser {
174174
}
175175

176176
fun parseInnerClassNode(innerClassNode: InnerClassNode): String {
177-
return "!access: ${Util.parseAccess(Util.CLASS, innerClassNode.access)}\n" +
177+
return "!access: ${Util.parseAccess(Util.CLASS, innerClassNode.access)} (${innerClassNode.access})\n" +
178178
"${Util.parseAsModifiersStr(Util.CLASS, innerClassNode.access)} ${Util.parseType(innerClassNode.outerName)}.${innerClassNode.innerName} -> ${Util.parseType(innerClassNode.name)}"
179179
}
180180

@@ -183,7 +183,7 @@ object ClassNodeParser {
183183
val buffer = StringBuilder()
184184

185185

186-
buffer.append("!access: ${Util.parseAccess(Util.FIELD, fieldNode.access)}\n")
186+
buffer.append("!access: ${Util.parseAccess(Util.FIELD, fieldNode.access)} (${fieldNode.access})\n")
187187

188188
fieldNode.signature?.let {
189189
buffer.append("!signature: $it\n")
@@ -209,7 +209,7 @@ object ClassNodeParser {
209209
fun parseMethodNode(methodNode: MethodNode, appendFrames: Boolean): String {
210210
val appender = Appender.Joiner(StringJoiner("\n"))
211211

212-
appender.append("!access: ${Util.parseAccess(Util.FIELD, methodNode.access)}")
212+
appender.append("!access: ${Util.parseAccess(Util.METHOD, methodNode.access)} (${methodNode.access})")
213213

214214
methodNode.signature?.let {
215215
appender.append("!signature: $it")
@@ -230,7 +230,7 @@ object ClassNodeParser {
230230
val parameterList = methodNode.parameters.orEmpty() as List<ParameterNode>
231231

232232
parameterList.forEach {
233-
appender.append("!parameter[name: ${it.name}, access: ${it.access} (${Util.parseAccess(Util.PARAMETER, it.access)})]")
233+
appender.append("!parameter[name: ${it.name}, access: ${Util.parseAccess(Util.PARAMETER, it.access)} (${it.access})]")
234234
}
235235

236236
val parameterAnnotations = ((methodNode.visibleParameterAnnotations.orEmpty() as Array<List<*>>) + (methodNode.invisibleParameterAnnotations.orEmpty() as Array<List<*>>)) as Array<List<AnnotationNode>>

‎src/main/kotlin/com/github/jonathanxd/bytecodedisassembler/MethodInstructionsParser.kt‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ package com.github.jonathanxd.bytecodedisassembler
2929

3030
import org.objectweb.asm.Handle
3131
import org.objectweb.asm.Opcodes
32+
import org.objectweb.asm.Type
3233
import org.objectweb.asm.tree.*
3334

3435
object MethodInstructionsParser {
@@ -85,7 +86,12 @@ object MethodInstructionsParser {
8586
else it
8687
}
8788

88-
normalAppender.append("ldc $cst // type: ${cst.javaClass.canonicalName}")
89+
val type = if (cst is Type)
90+
Class::class.java.canonicalName
91+
else
92+
cst.javaClass.canonicalName
93+
94+
normalAppender.append("ldc $cst // type: $type")
8995
}
9096
is IntInsnNode -> {
9197
if (it.operand == Opcodes.NEWARRAY) {
@@ -115,7 +121,7 @@ object MethodInstructionsParser {
115121
is InsnNode -> it.apply { normalAppender.append(Util.getOpcodeName(opcode)) }
116122
is IincInsnNode -> it.apply { normalAppender.append("iinc $`var` $incr") }
117123
is LineNumberNode -> it.apply {
118-
val ext = if(start != null) " -> ${labelMapper.getLabelName(start)}" else ""
124+
val ext = if (start != null) " -> ${labelMapper.getLabelName(start)}" else ""
119125
shortAppender.append(" LINE $line$ext")
120126
}
121127
is FieldInsnNode -> it.apply {

0 commit comments

Comments
 (0)