Skip to content

Fix Git Bash path in the Windows release workflow - #73

Merged
krotname merged 2 commits into
mainfrom
fix/release-windows-shell
Oct 20, 2026
Merged

krotname merged 2 commits into
mainfrom
fix/release-windows-shell

Conversation

@krotname

@krotname krotname commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Release jobs on the Windows runner stop at Resolve version because Git Bash is installed outside PATH. Add its checked installation directory to GITHUB_PATH before the version, checksum, and publication scripts. The release assets, build commands, checksums, and provenance checks remain intact.

Validation: actionlint and git diff --check passed. The installed Git Bash and required Unix tools were verified in a disposable isolated Windows container. The custom shell path was replaced with the runner-supported PATH mechanism after reviewing its parser.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T20:57:59.392468Z 8ef71d6 New commits
🔒 Security Review ✅ Completed 2026-10-20T20:55:47.795716Z 528ebb3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 528ebb3ed7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml Outdated
@krotname
krotname merged commit 5c34cc4 into main Oct 20, 2026
10 checks passed
@krotname
krotname deleted the fix/release-windows-shell branch October 20, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant