Skip to content

fix: provision release tools in isolated Windows jobs - #74

Merged
krotname merged 2 commits into
mainfrom
fix/release-jdk-bootstrap
Oct 20, 2026
Merged

krotname merged 2 commits into
mainfrom
fix/release-jdk-bootstrap

Conversation

@krotname

@krotname krotname commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

The Windows release job reported successful Java setup without installing the Java 17 compiler required by the project. Release now uses the pinned Temurin archive, detached-signature verification and local JDK installation already proven by the passing Windows CI.

The isolated runner image also has no GitHub CLI. The publishing job now downloads a pinned official CLI archive, validates the executable's trusted GitHub Authenticode signature and adds its directory to PATH before publishing.

Validation: actionlint and git diff --check pass. The PR checks and the subsequent Release run validate the workflow; a runtime tool probe confirmed GitHub CLI is absent from the image.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T22:10:51.546965Z 0bac52a PR opened
🔒 Security Review ✅ Completed 2026-10-20T22:15:23.298677Z 2c095ef Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@krotname krotname changed the title fix: install Java 17 reliably in Windows releases fix: provision release tools in isolated Windows jobs Oct 20, 2026
@krotname

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2c095ef48f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@krotname
krotname merged commit 13d28df into main Oct 20, 2026
8 checks passed
@krotname
krotname deleted the fix/release-jdk-bootstrap branch October 20, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant