Repository navigation
Remove Thread.sleep() from port forward test class - #4911
Merged
kubernetes-prow[bot] merged 2 commits intoOct 13, 2026
Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-prow[bot] merged 2 commits into
Conversation
kubernetes-prow
Bot
added
cncf-cla: yes
sarveshkaushal
force-pushed
the
sarveshkaushal/flaky-tests-1
branch
from
September 17, 2026 18:44
15c7c76 to
37e41cf
Compare
kubernetes-prow
Bot
added
size/M
Contributor
Author
|
/assign @brendandburns |
Contributor
|
As with the previous one please minimize diff for easier reviewing. |
sarveshkaushal
force-pushed
the
sarveshkaushal/flaky-tests-1
branch
from
September 26, 2026 01:04
37e41cf to
2461e14
Compare
Contributor
Author
|
@brendandburns - I have fixed the formatting changes in this PR. It was my IntelliJ which didn't pick the google formatter configured for the project. |
Contributor
|
/lgtm |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, sarveshkaushal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
kubernetes-prow
Bot
merged commit Oct 13, 2026
433ff48
into
kubernetes-client:master
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the fixed
Thread.sleep()inPortForwardTestwith semaphore-based synchronization.The test needs to close the WebSocket handler only after
PortForwardResult.inithas created the input stream which it will block while reading the port identifier. A test-specificWebSocketStreamHandlersubclass signals a semaphore when stream0is created, allowing the test to close the handler at the correct point.A second semaphore waits for
init()to finish after the handler is closed.This is related to issue #1223
Testing
Ran
mvn installon the root of the project.