Repository navigation
test(util): Replace Thread.sleep with latch in ExecCallbacksTest - #4969
Merged
kubernetes-prow[bot] merged 1 commit intoNov 9, 2026
Conversation
kubernetes-prow
Bot
added
cncf-cla: yes
Replaces the arbitrary 30-second sleep with a latch, preserving timeout behavior while allowing the background callback to be released when the test finishes.
flrnd
force-pushed
the
replace-sleep-with-latch-in-exec-callbacks-test
branch
from
November 3, 2026 19:46
f6c4d2d to
8b949ef
Compare
kubernetes-prow
Bot
added
size/M
Contributor
|
/lgtm |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, flrnd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
kubernetes-prow
Bot
merged commit Nov 9, 2026
73a7948
into
kubernetes-client:master
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the 30-second
Thread.sleep()inExecCallbacksTest.maxTimeout()with aCountDownLatch.This preserves the timeout behavior while allowing the background callback to be released in a
finallyblock instead of continuing to sleep after the test completes.Testing
Refs #1223