Skip to content

Use Thread.join instead of sleep in WaitTest #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubernetes-prow merged 1 commit into from
Nov 5, 2026
+1 −4
Merged

Use Thread.join instead of sleep in WaitTest #4971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions util/src/test/java/io/kubernetes/client/util/wait/WaitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,7 @@ void pollShutsDownExecutorThreadAfterReturning() throws InterruptedException {

// After poll returns the executor must have been shut down, so its worker thread terminates.
// Allow a short grace period for the interrupt/shutdown to take effect.
long deadline = System.currentTimeMillis() + 2000;
while (worker.isAlive() && System.currentTimeMillis() < deadline) {
Thread.sleep(10);
}
worker.join(2000);

assertThat(worker.isAlive())
.as("Wait.poll must shut down its executor so the worker thread is not leaked")
Expand Down
Loading