Skip to content

Publish FromConfigMap refreshes as coherent snapshots - #4979

Open
brendandburns with Copilot wants to merge 3 commits into
masterfrom
copilot/publish-refreshed-fromconfigmap-snapshot
Open

brendandburns with Copilot wants to merge 3 commits into
masterfrom
copilot/publish-refreshed-fromconfigmap-snapshot

Conversation

Copilot AI commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

ConfigMap refreshes previously updated entries individually, allowing readers to observe mixed old/new values and obsolete keys. This change publishes complete snapshots while keeping retained injected map references live.

  • Publication: Build an immutable copy, then publish it through a volatile reference. Deleted ConfigMaps and null data publish an empty snapshot.
  • Consistency: Iteration, forEach, and map copies observe one version. Views remain live; each iterator retains its captured snapshot. Separate map or view operations may span refreshes.
  • Compatibility: The injected map and its views become read-only; mutations throw UnsupportedOperationException. Callers needing local modifications must copy the map.
  • Regression coverage: Deterministically pause refresh mid-copy to verify coherent reads, snapshot-pinned traversal, and later updates through the original reference.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 3, 2026
Copilot AI linked an issue Nov 3, 2026 that may be closed by this pull request
@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2026
Copilot AI changed the title [WIP] Fix refresh method to publish coherent FromConfigMap data snapshot Publish FromConfigMap refreshes as coherent snapshots Nov 3, 2026
Copilot AI requested a review from brendandburns November 3, 2026 19:58
@brendandburns
brendandburns marked this pull request as ready for review November 3, 2026 20:00
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from yue9944882 November 3, 2026 20:00
@brendandburns
brendandburns force-pushed the copilot/publish-refreshed-fromconfigmap-snapshot branch from 8bea28f to dab6bde Compare November 4, 2026 18:52
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish refreshed FromConfigMap data as a coherent snapshot

2 participants