Skip to content

Honor the configured FromConfigMap polling interval - #4980

Open
brendandburns with Copilot wants to merge 2 commits into
masterfrom
copilot/honor-refresh-interval
Open

Honor the configured FromConfigMap polling interval#4980
brendandburns with Copilot wants to merge 2 commits into
masterfrom
copilot/honor-refresh-interval

Conversation

Copilot AI commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The default polling getter cached successful reads for five minutes, hiding ConfigMap changes despite a shorter kubernetes.manifests.refreshInterval.

  • Polling: Remove the fixed cache so every scheduled refresh reads the API server. Public APIs remain unchanged.
  • Regression coverage: Exercise the default getter against WireMock, verifying value updates and key additions/removals within a bounded wait.
  • Documentation: Clarify that the default getter reads the server on every refresh.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Not Signed

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 3, 2026
Copilot AI linked an issue Nov 3, 2026 that may be closed by this pull request
Honor the configured refresh interval for FromConfigMap polling #4973
Open
@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2026
@brendandburns
Honor configured FromConfigMap polling refresh cadence
72988d4 
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
@kubernetes-prow

kubernetes-prow Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2026
Copilot AI changed the title [WIP] Fix refresh interval for FromConfigMap polling Honor the configured FromConfigMap polling interval Nov 3, 2026
Copilot AI requested a review from brendandburns November 3, 2026 19:56
@brendandburns
brendandburns marked this pull request as ready for review November 3, 2026 20:01
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from yue9944882 November 3, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns
@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Copilot code review Copilot

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Honor the configured refresh interval for FromConfigMap polling

2 participants

@brendandburns