Repository navigation
Terminate owned delaying-queue executors on shutdown - #4983
Open
brendandburns with Copilot wants to merge 2 commits into
Open
brendandburns with Copilot wants to merge 2 commits into
brendandburns with Copilot wants to merge 2 commits into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Copilot
AI
changed the title
[WIP] Fix executor shutdown for internally owned delaying queue
Terminate owned delaying-queue executors on shutdown
Nov 3, 2026
brendandburns
marked this pull request as ready for review
November 3, 2026 20:01
brendandburns
force-pushed
the
copilot/terminate-internally-owned-delaying-queue-executor
branch
from
November 4, 2026 18:52
415cfdf to
d78659c
Compare
|
|
||
| class DefaultDelayingQueueTest { | ||
|
|
||
| private final DefaultDelayingQueue<String> queue = new DefaultDelayingQueue<>(); |
Contributor
There was a problem hiding this comment.
I'm worried that this will break if the tests run in parallel. Instead of making it a member variable in the Test class, enqueue each one in a list, and tear down all of them within the teardown method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default delaying and rate-limiting queues leave executor threads alive after shutdown, potentially preventing JVM termination. Waiting tasks can also remain blocked until a distant delayed-item deadline.