Skip to content

Fix DeltaFIFO relist deletion detection for queued objects - #4988

Draft
brendandburns with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-deltafifo-relist-misses-deletions
Draft

brendandburns with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-deltafifo-relist-misses-deletions

Conversation

Copilot AI commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

DeltaFIFO.replace missed objects present only in pending deltas when a backing store existed. A queued add could therefore populate the informer cache with an object absent from the authoritative relist.

  • Deletion detection: Scan pending deltas and the backing store, skipping queued keys during the store scan.
  • Tombstone correctness: Retain the newest queued object and unwrap existing tombstones to prevent nesting across repeated relists.
  • Regression coverage: Verify final informer cache state for queued-only, cached, and still-listed objects, plus deletion deduplication, delete/recreate ordering, and initial-sync accounting.

Public APIs remain unchanged.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

CLA Not Signed

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 4, 2026
@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2026
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2026
Copilot AI changed the title [WIP] Fix DeltaFIFO relist to handle deletions correctly Fix DeltaFIFO relist deletion detection for queued objects Nov 4, 2026
Copilot AI requested a review from brendandburns November 4, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeltaFIFO relist misses deletions for objects still pending in the queue

2 participants