Skip to content

Commit 5ec26ce

Browse files
authored
Clean up pong listener in exec keepalive
1 parent 0d44dad commit 5ec26ce

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎src/exec.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ export class Exec {
8484
const socket = conn as WebSocket.WebSocket & {
8585
ping?: () => void;
8686
on?: (event: string, listener: (...args: unknown[]) => void) => void;
87+
removeListener?: (event: string, listener: (...args: unknown[]) => void) => void;
8788
};
8889
if (typeof socket.ping !== 'function') {
8990
return;
@@ -98,10 +99,13 @@ export class Exec {
9899
}
99100
}
100101
}, pingIntervalMs);
101-
const clearKeepAlive = () => clearInterval(timer);
102102
const onPong = () => {
103103
awaitingPong = false;
104104
};
105+
const clearKeepAlive = () => {
106+
clearInterval(timer);
107+
socket.removeListener?.('pong', onPong);
108+
};
105109
socket.on?.('pong', onPong);
106110
socket.on?.('close', clearKeepAlive);
107111
socket.on?.('error', clearKeepAlive);

0 commit comments

Comments
 (0)