Skip to content

Commit cfb2fb2

Browse files
Merge pull request #2910 from davidgamero/david/release-c8-compat-fix-node26
bump yargs 17.7.3 to fix release release workflow and c8 node26 compat
2 parents 3c45fd4 + 02c2303 commit cfb2fb2

2 files changed

Lines changed: 4 additions & 10 deletions

File tree

‎.github/workflows/test.yml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,7 @@ jobs:
4646
# and package-lock.json. Needs to run before npm install
4747
- run: node version-check.js
4848
- run: npm ci
49-
# Node 26 has a known incompatibility: extension-less files in "type: module"
50-
# packages are treated as ESM, causing c8's require('yargs/yargs') to fail.
51-
# Fall back to plain unit tests without coverage on Node 26 until upstream fixes this.
52-
- if: matrix.node != '26'
53-
run: npm test
54-
- if: matrix.node == '26'
55-
run: npm run test-no-coverage
49+
- run: npm test
5650
- run: npm run lint
5751
- run: npm audit --audit-level=critical
5852
- run: npm run build-with-tests && npm run test-transpiled

‎package-lock.json‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)