Skip to content

typehinting: add V1Duration pydantic type - #2765

Closed
msfrucht wants to merge 1 commit into
kubernetes-client:masterfrom
msfrucht:duration_quantity_typehinting
Closed

typehinting: add V1Duration pydantic type#2765
msfrucht wants to merge 1 commit into
kubernetes-client:masterfrom
msfrucht:duration_quantity_typehinting

Conversation

@msfrucht

@msfrucht msfrucht commented Oct 28, 2026

Copy link
Copy Markdown

What type of PR is this?

Feature/API Addition

Add one of the following kinds:
/kind feature

Optionally add one or more of the following kinds if applicable:
/kind cleanup
/kind documentation

What this PR does / why we need it:

This adds a Pydantic custom type usable as a drop-in metav1.Duration that can be used within custom Pydantic models. This is meant for use with model_dump/model_verify through the CustomObjectsApi to serialize/deserialize models for custom resources.

Example:
Velero Backup objects uses metav1.Duration to describe how long should stick around before expiration as well as various timeout fields. https://github.com/velero-io/velero/blob/v1.18.4/pkg/apis/velero/v1/backup_types.go#L114

Which issue(s) this PR fixes:

Fixes # #2764

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Adds meta V1Duration class.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@msfrucht
typehinting: add V1Duration pydantic type
0e50391 
Add V1Duration, an annotated timedelta type for GEP-2257 durations in
custom objects, and add type hints to parse_duration. Also export
format_duration from kubernetes.utils.

Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>
@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 28, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 28, 2026

Copy link
Copy Markdown

CLA Not Signed

@kubernetes-prow

kubernetes-prow Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Welcome @msfrucht!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 28, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from roycaihw and yliaog October 28, 2026 22:00
@kubernetes-prow

kubernetes-prow Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msfrucht
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2026
@msfrucht msfrucht closed this Oct 28, 2026
@msfrucht

msfrucht commented Oct 28, 2026

Copy link
Copy Markdown
Author

Reviewing organization CLA situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw
@yliaog yliaog Awaiting requested review from yliaog

Assignees

No one assigned

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@msfrucht