Repository navigation
Conversation
/kind feature Prior to version 36.0.0, the async client was a seperate pypi package. With version 36.0.0 including the async client in the main package, this increased the vulnerability/install footprint for users who don't require the asyncio client by now having to install several new dependency packages. This change makes asyncio dependencies an extra that will not be install by default. These dependencies are now only installed by specifying the asyncio extra - `pip install kubernetes[asyncio]`. Fixes kubernetes-client#2739 Yes, users who install from pypi and need asyncio will need to `pip install kubernetes[asyncio]` to have all the dependencies installed. ```release-note Breaking change: the asyncio client's dependencies, such as `aiohttp` and `aiohttp-retry`, are no longer install by `pip install kubernetes`. Applications that user `kubernetes.aio` must install with `pip install kubernetes[asyncio]`. ``` Proposals), usage docs, etc.: Signed-off-by: Jason Kelly <jason.kelly@nokia.com>
|
|
|
Welcome @jdork0! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jdork0 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Prior to version 36.0.0, the async client was a seperate pypi package. With version 36.0.0 including the async client in the main package, this increased the vulnerability/install footprint for users who don't require the asyncio client + dependencies.
This change makes asyncio dependencies an extra that will not be installed by default. These dependencies are now only installed by specifying the asyncio extra -
pip install kubernetes[asyncio].Which issue(s) this PR fixes:
Fixes #2739
Special notes for your reviewer:
Tested pip install kubernetes.whl and kubernetes.whl[asyncio] and compared pip freeze list post install.
Does this PR introduce a user-facing change?
Yes, users who install from pypi and need async client will need to
pip install kubernetes[asyncio]to have all the dependencies installed.