Repository navigation
Conversation
kubernetes-prow
Bot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chala2001 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
/assign |
Contributor
Author
|
@roycaihw could you approve the workflow run? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Follow-up to #2690. Leader election now records the leader transition count, like client-go does. It's stored as
spec.leaseTransitionson a Lease andleaderTransitionson a ConfigMap. The leader keeps the count on renew, and it goes up by one when another candidate takes the lock.Locks without the field read as 0.
Which issue(s) this PR fixes:
Follow-up to #2690
Special notes for your reviewer:
Sync client only. Happy to do the asyncio one next.
Does this PR introduce a user-facing change?