docs: correct stocktake tally and normalize impeccable license string - #20
Merged
Merged
Conversation
The stocktake table recorded adhd as KEEP even though its body was edited in the same pass to drop Claude Code and GrokBuild as runtime names. The evidence cell already described the edit, so the row and the tally disagreed with each other and with the CHANGELOG, which counted four host-name bodies while the tally showed three UPDATE. adhd moves to UPDATE (applied) with a writing-for-agents handoff. Recount from the table rows: 56 KEEP, 2 COMPRESS, 4 UPDATE, 0 MERGE, 0 RETIRE, total 62. impeccable frontmatter declared "Apache 2.0" while vendor/license-audit.json records "Apache-2.0". The test normalizes the form, so this was cosmetic, but the audit entry carried an evidence string of "SKILL.md frontmatter (Apache 2.0)" whose parenthetical only existed to flag the mismatch. Normalizing the frontmatter without it would have left the citation quoting a string no longer in the file, so both move together and the entry now matches its siblings. Closes follow-up 3 in docs/stocktake-1.8.3.md. Follow-ups 1, 2, and 4 stay open: the A/B baseline, the image_gen tool-family naming decision, and the 28 intentionally license-free frontmatters. No skill bodies changed apart from that one license string. VERSION stays 1.8.2, no 1.8.3 heading, no tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs consistency only. No behavior change, no new skills, no version bump.
1. Stocktake tally
adhdwas recorded asKEEPin the verdict table even though its body wasedited in the same pass to stop naming
Claude CodeandGrokBuildas ifeither were this runtime. The row's evidence cell already described that edit,
so the table contradicted itself, and the CHANGELOG described four host-name
bodies while the tally showed three
UPDATE.adhdmoves toUPDATE (applied)with awriting-for-agentshandoff.Recounted programmatically from the table rows rather than by hand:
The CHANGELOG
Unreleasedtally string is updated to match. Its GrokBuildbullet already said "four skill bodies" and needed no edit, which is what
made the mismatch visible.
2. impeccable license string
Frontmatter read
Apache 2.0;vendor/license-audit.jsonrecordsApache-2.0.tests/test_skills.pynormalizes the form, so this wascosmetic.
One extra edit beyond the literal request: the audit entry's evidence string
was
"SKILL.md frontmatter (Apache 2.0)". That parenthetical existed only toflag the unhyphenated frontmatter. Normalizing the frontmatter alone would
have left the citation quoting a string no longer present in the file, so both
move together and the entry now matches its siblings' plain
"SKILL.md frontmatter". The recorded license andredistributionvalues areuntouched; no test asserts the evidence text.
Follow-up 3 in
docs/stocktake-1.8.3.mdis struck through as resolved.Follow-ups 1, 2, and 4 stay open.
Verification
python3 -m unittest tests.test_skills— 10 tests, OKpython3 -m unittest tests.test_license_audit— 2 tests, OKpython3 -m unittest discover -s tests— 315 tests, OK (skipped=2)git diff --check— cleanjson.loadonvendor/license-audit.json— parses, entry verified57 KEEP/3 UPDATE/Apache 2.0— no hitsoutside a third-party citation in
full-performance-audit/references/sources.mdNot touched
VERSIONstays1.8.2, no1.8.3heading, no tag, no release. No skill bodychanged apart from that one license string.
GrokBuild image_gentool-familynames and the A/B baseline are untouched.