Commit 88a430c
authored
Fix broadcast "list all channels" to use /all-channels endpoint (#240)
The `.listAll` broadcast operation was targeting `/1/apps/{bundleID}/channels`,
but Apple exposes "read all channels" on a distinct endpoint:
`GET /1/apps/{bundleID}/all-channels`. Against real APNs the old path is not the
list endpoint, so `readAllChannelIDs()` would not return the channel list.
- Route `.listAll` to `/all-channels` in APNSBroadcastRequest.
- Update APNSTestServer to serve `/all-channels` for listing and to require the
`apns-channel-id` header on `GET /channels` (so it can no longer silently mirror
the old, incorrect behaviour and mask a regression).
- Add `testOperationPaths` pinning the path contract for every operation.1 parent ff38db1 commit 88a430c
3 files changed
Lines changed: 28 additions & 5 deletions
File tree
- Sources
- APNSCore/Broadcast
- APNSTestServer
- Tests/APNSTests/Broadcast
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
51 | 55 | | |
52 | 56 | | |
53 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
144 | 147 | | |
145 | | - | |
146 | | - | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
147 | 155 | | |
148 | | - | |
| 156 | + | |
149 | 157 | | |
150 | 158 | | |
151 | 159 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
156 | 167 | | |
157 | 168 | | |
158 | 169 | | |
| |||
0 commit comments