Encryption fix

Author: kyleu

app/util/encryption.go

@@ -115,9 +115,8 @@ func HashFNV128UUID(s string) uuid.UUID {
 
 // HashSHA256 returns a Base64-encoded string representing the SHA-256 hash of the argument.
 func HashSHA256(s string) string {
-	h := sha256.New()
-	ret := h.Sum([]byte(s))
-	return base64.URLEncoding.EncodeToString(ret)
+	h := sha256.Sum256([]byte(s))
+	return base64.URLEncoding.EncodeToString(h[:])
 }
 
 func getKey(logger Logger) []byte {

app/util/encryption_test.go

@@ -13,8 +13,8 @@ var hashTests = []struct {
 	hash32    uint32
 	hashSHA   string
 }{
-	{plaintext: "Hello, world!", hash32: 3985698964, hashSHA: "SGVsbG8sIHdvcmxkIeOwxEKY_BwUmvv0yJlvuSQnrkHkZJuTTKSVmRt4UrhV"},
-	{plaintext: "Goodbye, cruel world!", hash32: 55824456, hashSHA: "R29vZGJ5ZSwgY3J1ZWwgd29ybGQh47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU="},
+	{plaintext: "Hello, world!", hash32: 3985698964, hashSHA: "MV9b23bQeMQ7isAGTkoBZGErH853yGk0W_yUx1iU7dM="},
+	{plaintext: "Goodbye, cruel world!", hash32: 55824456, hashSHA: "Rpwk-Ulwczqp08GLqIuBalVyzchihsMBB-P_y574jgU="},
 }
 
 func TestEncryptDecrypt(t *testing.T) {

module/core/app/util/encryption.go

@@ -115,9 +115,8 @@ func HashFNV128UUID(s string) uuid.UUID {
 
 // HashSHA256 returns a Base64-encoded string representing the SHA-256 hash of the argument.
 func HashSHA256(s string) string {
-	h := sha256.New()
-	ret := h.Sum([]byte(s))
-	return base64.URLEncoding.EncodeToString(ret)
+	h := sha256.Sum256([]byte(s))
+	return base64.URLEncoding.EncodeToString(h[:])
 }
 
 func getKey(logger Logger) []byte {

module/core/app/util/encryption_test.go

@@ -13,8 +13,8 @@ var hashTests = []struct {
 	hash32    uint32
 	hashSHA   string
 }{
-	{plaintext: "Hello, world!", hash32: 3985698964, hashSHA: "SGVsbG8sIHdvcmxkIeOwxEKY_BwUmvv0yJlvuSQnrkHkZJuTTKSVmRt4UrhV"},
-	{plaintext: "Goodbye, cruel world!", hash32: 55824456, hashSHA: "R29vZGJ5ZSwgY3J1ZWwgd29ybGQh47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU="},
+	{plaintext: "Hello, world!", hash32: 3985698964, hashSHA: "MV9b23bQeMQ7isAGTkoBZGErH853yGk0W_yUx1iU7dM="},
+	{plaintext: "Goodbye, cruel world!", hash32: 55824456, hashSHA: "Rpwk-Ulwczqp08GLqIuBalVyzchihsMBB-P_y574jgU="},
 }
 
 func TestEncryptDecrypt(t *testing.T) {