support for multiple ingress controllers - #388
Merged
MonolithProjects merged 10 commits intoApr 6, 2026
Merged
Conversation
The airgap "exists" workflow registers artifact stats into `artifacts.results`, but the previous template iterated over `artifacts.values()` and attempted to read `writeable` from non-mapping values (e.g. the `results` list), which could crash with: "object of type 'list' has no attribute 'writeable'". Compute artifacts_writeable from `artifacts.results[*].stat.writeable` instead, avoiding the invalid access and allowing the role to proceed.
Contributor
Author
|
Heyyy, is there something I can do, to help you to move this PR forward? |
Collaborator
|
Hi @PlayMTL , sorry for the delay. Will check it this week. |
MonolithProjects
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ingress-nginx is reaching EOL. This pr implements the ability to deploy multiple ingress controllers (ingress-nginx & traefik) simultaneously. The user must still provide a custom configuration (HelmChartConfig) to avoid port conflicts.
I have tried to implement this a "non breaking change" way for existing clusters.
Type of change
How Has This Been Tested?
Verified in a test environment running first only ingress-nginx then ingress-nginx & traefik simultaneously.