Adding customizable defaults to kube-vip template. Add support for valueFrom in rke2_kubevip_args. - #393
Merged
Conversation
…lueFrom in rke2_kubevip_args.
MonolithProjects
requested changes
May 10, 2026
rumblpak
commented
May 10, 2026
rumblpak
left a comment
rumblpak
left a comment
Contributor
Author
There was a problem hiding this comment.
Resolved all issues and merge conflicts based on current main.
MonolithProjects
requested changes
Jun 8, 2026
Contributor
Author
|
@MonolithProjects Resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding customizable defaults to the kube-vip template. This allows users that want to disable ARP mode in order to enable BGP mode ease to do so. This also adds support for using valueFrom in rke2_kubevip_args so reflected values can be included.
Type of change
How Has This Been Tested?
No. (I'm new to ansible development and would be happy to test if someone could link me a document on how to do so)