docs(sdk): inventory change-detector tests - #5974
Closed
Mason Daugherty (mdrxy) wants to merge 2 commits into
Closed
docs(sdk): inventory change-detector tests#5974Mason Daugherty (mdrxy) wants to merge 2 commits into
Mason Daugherty (mdrxy) wants to merge 2 commits into
Conversation
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
github-actions
Bot
added
deepagents
Mason Daugherty (mdrxy)
marked this pull request as ready for review
August 28, 2026 22:29
![open-swe[bot]](https://avatars.githubusercontent.com/in/1395372?s=60&v=4){kind=small}
|
|
||
| The audit is intentionally narrower than a general test-quality review. A test is | ||
| not listed merely because it uses mocks, accesses a private helper, is redundant, | ||
| is brittle, or has weak assertions. Snapshot tests for model-facing output, |
Contributor
There was a problem hiding this comment.
🔵 Audit baseline undercounts test functions
At the stated baseline, parsing the 79 Python files under libs/deepagents/tests yields 2,464 test* function definitions, not 2,463. This makes the claimed complete-audit baseline internally inaccurate and causes future re-audits to compare against the wrong total. Please update the count to 2,464 (and the matching PR summary).
(Refers to line 19)
Your feedback helps Open SWE learn. React with 👍 or 👎 to tell us if this review comment was useful.
Suggested change
| is brittle, or has weak assertions. Snapshot tests for model-facing output, | |
| - Test functions reviewed: 2,464 |
Contributor
|
Superseded by #5975, which removes the audited change-detector tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audits all 2,463 Python test functions under
libs/deepagents/testsagainst the strict change-detector definition from the Google Testing Blog.The new tracking file records 49 findings with exact pytest node IDs, concrete reasons, and rewrite-or-delete recommendations. It also documents the audit baseline, scope, exclusions, and maintenance process so the inventory can be updated deliberately.
Made by Open SWE