test(sdk): remove change-detector tests - #5975
Open
Mason Daugherty (mdrxy) wants to merge 3 commits into
Open
Conversation
Remove the 49 implementation-coupled tests identified in the audit so behavior-preserving refactors do not require mechanical updates. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
github-actions
Bot
added
deepagents
Mason Daugherty (mdrxy)
marked this pull request as ready for review
August 28, 2026 22:34
![open-swe[bot]](https://avatars.githubusercontent.com/in/1395372?s=60&v=4){kind=small}
Restore coverage for requirements that the audit marked for rewriting while keeping only redundant implementation checks removed. Relax the Nemotron middleware assertion to preserve capabilities without pinning exact ordering.\n\nCo-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
Replace the deleted backend-identity assertion with an observable compact-history write through the configured backend.\n\nCo-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 13 change-detector tests from the #5974 audit whose assertions are redundant or do not protect a meaningful contract. One additional implementation-coupled compact-backend test is replaced with behavioral coverage, for a net removal of 13 tests.
Requirements marked for rewrite remain covered, including external sandbox limits and heredoc framing, timeout headroom, middleware configuration and backend behavior, summarization defaults and token-counting performance, artifact paths, provider profile registration, environment ordering, and version lookup caching. The Nemotron profile assertion now checks critical middleware capabilities without pinning their exact ordering.
Made by Open SWE