Skip to content

feat(api): update API spec from langfuse/langfuse b19a2f5 - #915

Merged
niklassemmler merged 2 commits into
mainfrom
api-spec-bot-b19a2f5-31818026166-1
Aug 17, 2026
Merged

feat(api): update API spec from langfuse/langfuse b19a2f5#915
niklassemmler merged 2 commits into
mainfrom
api-spec-bot-b19a2f5-31818026166-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This generated API update synchronizes client types and documentation with the latest backend specification.

  • Adds sessionId filtering to the observations v2 request and serializes it into the API query.
  • Documents semantic-root filtering for metrics and evaluation rules.
  • Clarifies blob export compatibility, comment author membership, and SCIM password behavior.
  • Updates scores endpoint documentation.

Confidence Score: 5/5

The PR appears safe to merge because the behavioral request change is consistently typed, exported, and serialized, while the remaining changes are coherent documentation updates.

The new observations filter follows established query-parameter conventions, and the documented semantic-root examples are supported by the existing generated filter types and exports; no actionable failure remains.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

Context used:

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
langfuse-js Ready Ready Preview Aug 17, 2026 1:23pm

Request Review

@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — this is an auto-generated API client update mirroring the langfuse OpenAPI spec (Fern codegen), safe to approve.

What was reviewed: the diff is almost entirely JSDoc/comment updates (deprecation notice removal on scores v2 endpoints, clarified export-source and password-field docs, new isRootObservation/boolean-filter docs). The one functional change — a new sessionId query param on observations.getMany — follows the exact existing pattern used for userId/traceId (null-check, then set into _queryParams), so it carries the same low risk as the rest of the generated client code.

Extended reasoning...

Overview

PR regenerates the TypeScript API client from the langfuse OpenAPI spec (commit b19a2f5). Touches 10 generated files under packages/core/src/api: mostly JSDoc comment clarifications (blob storage export source semantics, comment/SCIM password field docs, metrics/evaluation-rule filter docs) plus one functional addition — a sessionId optional query parameter on GET /api/public/v2/observations, wired through Client.ts and GetObservationsV2Request.ts.

Security risks

None identified. No auth, crypto, or permission logic is touched. The new sessionId param is passed through as an opaque query string exactly like the existing userId/traceId params — no injection surface introduced (values are placed into a query-params record consumed by the existing core.fetcher, not concatenated into a URL or SQL).

Level of scrutiny

Low. This is machine-generated client code mirroring a server-side API spec change; the TS SDK has no independent business logic to get wrong here — it's declarative request/response shape mirroring. The functional diff (new query param) is a copy-paste of an existing, already-tested code path.

Other factors

No test changes accompany this PR, which is consistent with this repo's pattern for generated-client PRs (no existing tests assert on-the-wire query param handling for this resource). No outstanding review comments to address; only bot comments are present in the timeline.

@niklassemmler

Copy link
Copy Markdown

LGTM

@niklassemmler
niklassemmler enabled auto-merge (squash) August 17, 2026 13:23
@niklassemmler
niklassemmler merged commit 76a4c73 into main Aug 17, 2026
14 checks passed
@niklassemmler
niklassemmler deleted the api-spec-bot-b19a2f5-31818026166-1 branch August 17, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants