Skip to content

feat(api): update API spec from langfuse/langfuse 4e0ce09 - #927

Merged
wochinge merged 1 commit into
mainfrom
api-spec-bot-4e0ce09-33365995214-1
Aug 31, 2026
Merged

feat(api): update API spec from langfuse/langfuse 4e0ce09#927
wochinge merged 1 commit into
mainfrom
api-spec-bot-4e0ce09-33365995214-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This generated API update introduces a readable V2 evaluation-rule model and uses it for update, get, and list response contracts while retaining the stricter write-oriented model.

  • Changes evaluation-rule update responses to ReadableV2EvaluationRule.
  • Allows read responses to represent historical filter shapes through EvaluationRuleReadFilter.
  • Exports the new generated type and moves its API example from the write-oriented model.

Confidence Score: 5/5

The PR appears safe to merge, with the generated response types and public exports remaining internally consistent.

The update, get, and list response models now consistently distinguish readable historical filter data from the stricter write contract, and all newly referenced types resolve through the existing export hierarchy.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
langfuse-js Ready Ready Preview Aug 31, 2026 6:56am

Request Review

@langfuse-bot
langfuse-bot requested a review from wochinge August 31, 2026 06:56
@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — a mechanical, auto-generated Fern SDK update to the unstable evaluationRules types/client.

What was reviewed: the update() client method's return type change from EvaluationRule to the new ReadableV2EvaluationRule; the new ReadableV2EvaluationRule type shape and its filter/mapping fields against the pre-existing analogous stable type in evaluationRules/types/EvaluationRule.ts (same EvaluationRuleReadFilter type is already used there, confirming it's a valid, existing type); and the ReadableEvaluationRule union and index.ts export update. No hand-written logic or tests were touched.

Extended reasoning...

Overview

This PR is an auto-generated Fern SDK update (all files carry the "auto-generated by Fern" header) affecting the unstable.evaluationRules resource in packages/core. It adds a new ReadableV2EvaluationRule interface (mirroring the old EvaluationRule but typing filter as LangfuseAPI.EvaluationRuleReadFilter[] instead of the stricter unstable filter type), re-exports it, and switches ReadableEvaluationRule and the update() client method's return type to use it. The old EvaluationRule interface remains, minus its large @ example doc comment, and is still exported from index.ts.

Security risks

None. This is purely a type/client-surface change with no new I/O, auth, or data-handling logic — the HTTP call in Client.ts is unchanged except for a type-only cast on the response body.

Level of scrutiny

Low. This is mechanical generated code mirroring an existing pattern already present elsewhere in the codebase (the stable evaluationRules/types/EvaluationRule.ts already uses LangfuseAPI.EvaluationRuleReadFilter[] for its filter field), and I confirmed that type exists and is defined in evaluationCommons/types/EvaluationRuleReadFilter.ts. No hand-written logic, tests, or runtime behavior are affected — the change only widens/relaxes the read-side filter type for an "unstable" API surface, consistent with the stated purpose (accepting historical filter shapes on read).

Other factors

I could not run tsc in this sandboxed environment (Bash permission denied for that command), so I relied on manual verification that referenced types (EvaluationRuleReadFilter, EvaluationRuleEvaluatorAssignment, EvaluationRuleTarget, PromptVariableMappingRead) already exist elsewhere in the generated tree and are used identically in the sibling stable module. The PR has a linked Vercel comment (likely a preview deployment check) with no CHANGES_REQUESTED or unresolved objections visible in the timeline. This is a small, self-contained, generated-code change with no ambiguity, so I'm approving.

@wochinge
wochinge merged commit 7b11849 into main Aug 31, 2026
18 checks passed
@wochinge
wochinge deleted the api-spec-bot-4e0ce09-33365995214-1 branch August 31, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants