Skip to content

Commit 076e5a2

Browse files
Aryan SrivastavaAryan Srivastava
authored andcommitted
fix(propagation): coerce non-string metadata values to string
Allows propagate_attributes to accept and automatically convert non-string metadata values (int, float, bool) to strings instead of silently dropping them. This resolves tracing compatibility issues with LangGraph integrations.
1 parent 50e8f91 commit 076e5a2

2 files changed

Lines changed: 37 additions & 7 deletions

File tree

‎langfuse/_client/propagation.py‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,11 @@ def _detach_context_token_safely(token: Any) -> None:
9090
except Exception:
9191
pass
9292

93-
9493
def propagate_attributes(
9594
*,
9695
user_id: Optional[str] = None,
9796
session_id: Optional[str] = None,
98-
metadata: Optional[Dict[str, str]] = None,
97+
metadata: Optional[Dict[str, Any]] = None,
9998
version: Optional[str] = None,
10099
tags: Optional[List[str]] = None,
101100
trace_name: Optional[str] = None,
@@ -229,7 +228,7 @@ def _propagate_attributes(
229228
*,
230229
user_id: Optional[str] = None,
231230
session_id: Optional[str] = None,
232-
metadata: Optional[Dict[str, str]] = None,
231+
metadata: Optional[Dict[str, Any]] = None,
233232
version: Optional[str] = None,
234233
tags: Optional[List[str]] = None,
235234
trace_name: Optional[str] = None,
@@ -247,10 +246,9 @@ def _propagate_attributes(
247246
"trace_name": trace_name,
248247
}
249248

250-
propagated_metadata_attributes: Dict[str, Optional[Dict[str, str]]] = {
249+
propagated_metadata_attributes: Dict[str, Optional[Dict[str, Any]]] = {
251250
"metadata": metadata,
252251
}
253-
254252
if experiment:
255253
for key, value in experiment.items():
256254
if key in ("experiment_metadata", "experiment_item_metadata"):
@@ -286,8 +284,11 @@ def _propagate_attributes(
286284
validated_metadata: Dict[str, str] = {}
287285

288286
for key, value in metadata_value.items():
289-
if _validate_string_value(value=value, key=f"{metadata_key}.{key}"):
290-
validated_metadata[key] = value
287+
if value is None:
288+
continue
289+
string_value = value if isinstance(value, str) else str(value)
290+
if _validate_string_value(value=string_value, key=f"{metadata_key}.{key}"):
291+
validated_metadata[key] = string_value
291292

292293
if validated_metadata:
293294
context = _set_propagated_attribute(

‎tests/unit/test_propagate_attributes.py‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,36 @@ def test_mixed_valid_invalid_metadata(self, langfuse_client, memory_exporter):
489489
self.verify_missing_attribute(
490490
child_span, f"{LangfuseOtelSpanAttributes.TRACE_METADATA}.invalid_key"
491491
)
492+
def test_metadata_coercion_of_non_string_values(self, langfuse_client, memory_exporter):
493+
"""Verify metadata values that are not strings (int, float, bool) are coerced to strings."""
494+
with langfuse_client.start_as_current_observation(name="parent-span"):
495+
with propagate_attributes(
496+
metadata={
497+
"int_val": 42, # type: ignore
498+
"float_val": 3.14, # type: ignore
499+
"bool_val": True, # type: ignore
500+
}
501+
):
502+
child = langfuse_client.start_observation(name="child-span")
503+
child.end()
492504

505+
# Verify child has all metadata keys coerced to string values
506+
child_span = self.get_span_by_name(memory_exporter, "child-span")
507+
self.verify_span_attribute(
508+
child_span,
509+
f"{LangfuseOtelSpanAttributes.TRACE_METADATA}.int_val",
510+
"42",
511+
)
512+
self.verify_span_attribute(
513+
child_span,
514+
f"{LangfuseOtelSpanAttributes.TRACE_METADATA}.float_val",
515+
"3.14",
516+
)
517+
self.verify_span_attribute(
518+
child_span,
519+
f"{LangfuseOtelSpanAttributes.TRACE_METADATA}.bool_val",
520+
"True",
521+
)
493522

494523
class TestPropagateAttributesNesting(TestPropagateAttributesBase):
495524
"""Tests for nested propagate_attributes contexts."""

0 commit comments

Comments
 (0)