Skip to content

Commit 1d1910f

Browse files
Aryan SrivastavaAryan Srivastava
authored andcommitted
fix(propagation): support json serialization for container metadata values
1 parent 0e29ec9 commit 1d1910f

2 files changed

Lines changed: 23 additions & 2 deletions

File tree

‎langfuse/_client/propagation.py‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,16 @@ def _propagate_attributes(
287287
for key, value in metadata_value.items():
288288
if value is None:
289289
continue
290-
string_value = value if isinstance(value, str) else ("true" if value is True else "false" if value is False else str(value))
290+
if isinstance(value, str):
291+
string_value = value
292+
elif isinstance(value, bool):
293+
string_value = "true" if value else "false"
294+
elif isinstance(value, (dict, list, tuple)):
295+
import json
296+
string_value = json.dumps(value)
297+
else:
298+
string_value = str(value)
299+
291300
if _validate_string_value(value=string_value, key=f"{metadata_key}.{key}"):
292301
validated_metadata[key] = string_value
293302

‎tests/unit/test_propagate_attributes.py‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,13 +491,15 @@ def test_mixed_valid_invalid_metadata(self, langfuse_client, memory_exporter):
491491
)
492492

493493
def test_metadata_coercion_of_non_string_values(self, langfuse_client, memory_exporter):
494-
"""Verify metadata values that are not strings (int, float, bool) are coerced to strings."""
494+
"""Verify metadata values that are not strings (int, float, bool, dict, list) are coerced to strings."""
495495
with langfuse_client.start_as_current_observation(name="parent-span"):
496496
with propagate_attributes(
497497
metadata={
498498
"int_val": 42, # type: ignore
499499
"float_val": 3.14, # type: ignore
500500
"bool_val": True, # type: ignore
501+
"dict_val": {"nested": "val"}, # type: ignore
502+
"list_val": [1, 2], # type: ignore
501503
}
502504
):
503505
child = langfuse_client.start_observation(name="child-span")
@@ -520,6 +522,16 @@ def test_metadata_coercion_of_non_string_values(self, langfuse_client, memory_ex
520522
f"{LangfuseOtelSpanAttributes.TRACE_METADATA}.bool_val",
521523
"true",
522524
)
525+
self.verify_span_attribute(
526+
child_span,
527+
f"{LangfuseOtelSpanAttributes.TRACE_METADATA}.dict_val",
528+
'{"nested": "val"}',
529+
)
530+
self.verify_span_attribute(
531+
child_span,
532+
f"{LangfuseOtelSpanAttributes.TRACE_METADATA}.list_val",
533+
"[1, 2]",
534+
)
523535

524536
class TestPropagateAttributesNesting(TestPropagateAttributesBase):
525537
"""Tests for nested propagate_attributes contexts."""

0 commit comments

Comments
 (0)