Skip to content

Commit 4aa69a3

Browse files
test: expect flattened metadata keys for v5 (#2001)
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
1 parent bb217a3 commit 4aa69a3

4 files changed

Lines changed: 12 additions & 23 deletions

File tree

‎tests/e2e/test_core_sdk.py‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -360,13 +360,6 @@ def test_create_text_score():
360360
)
361361

362362

363-
@pytest.mark.xfail(
364-
strict=False,
365-
reason=(
366-
"Needs the Langfuse platform release that adds timestamp to POST /scores "
367-
"(langfuse prep-js-v6-py-v5-sdk-majors). Remove this marker once it ships."
368-
),
369-
)
370363
def test_create_score_with_custom_timestamp():
371364
langfuse = Langfuse()
372365

‎tests/e2e/test_decorators.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,7 +1114,7 @@ def main():
11141114
in (trace.output or {}).get("context", {}).get("nested", "")
11151115
and any(
11161116
"@@@langfuseMedia:type=application/pdf|id="
1117-
in observation.metadata.get("context", {}).get("nested", "")
1117+
in observation.metadata.get("context.nested", "")
11181118
for observation in trace.observations
11191119
if observation.metadata
11201120
)
@@ -1133,10 +1133,10 @@ def main():
11331133
observation = trace_data.observations[0]
11341134
assert (
11351135
"@@@langfuseMedia:type=application/pdf|id="
1136-
in observation.metadata["context"]["nested"]
1136+
in observation.metadata["context.nested"]
11371137
)
11381138
parsed_reference_string = LangfuseMedia.parse_reference_string(
1139-
observation.metadata["context"]["nested"]
1139+
observation.metadata["context.nested"]
11401140
)
11411141
assert parsed_reference_string["content_type"] == "application/pdf"
11421142
assert parsed_reference_string["media_id"] is not None

‎tests/e2e/test_media.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@ def test_replace_media_reference_string_in_object():
3535
is_result_ready=lambda observations: (
3636
re.match(
3737
r"^@@@langfuseMedia:type=audio/wav\|id=.+\|source=base64_data_uri@@@$",
38-
observations[0].metadata.get("context", {}).get("nested", ""),
38+
observations[0].metadata.get("context.nested", ""),
3939
)
4040
is not None
4141
),
4242
)
4343
assert len(fetched_observations) == 1
4444
fetched_observation = fetched_observations[0]
45-
media_ref = fetched_observation.metadata["context"]["nested"]
45+
media_ref = fetched_observation.metadata["context.nested"]
4646
assert re.match(
4747
r"^@@@langfuseMedia:type=audio/wav\|id=.+\|source=base64_data_uri@@@$",
4848
media_ref,
@@ -53,20 +53,20 @@ def test_replace_media_reference_string_in_object():
5353
)
5454

5555
expected_base64 = f"data:audio/wav;base64,{base64_audio}"
56-
assert resolved_obs["metadata"]["context"]["nested"] == expected_base64
56+
assert resolved_obs["metadata"]["context.nested"] == expected_base64
5757

5858
span2 = langfuse.start_observation(
5959
name=f"2-{mock_trace_name}",
60-
metadata={"context": {"nested": resolved_obs["metadata"]["context"]["nested"]}},
60+
metadata={"context": {"nested": resolved_obs["metadata"]["context.nested"]}},
6161
).end()
6262

6363
langfuse.flush()
6464

6565
fetched_observations2 = wait_for_observations(
6666
span2.trace_id,
6767
is_result_ready=lambda observations: (
68-
observations[0].metadata.get("context", {}).get("nested") == media_ref
68+
observations[0].metadata.get("context.nested") == media_ref
6969
),
7070
)
7171
assert len(fetched_observations2) == 1
72-
assert fetched_observations2[0].metadata["context"]["nested"] == media_ref
72+
assert fetched_observations2[0].metadata["context.nested"] == media_ref

‎tests/live_provider/test_openai.py‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -999,17 +999,13 @@ def test_structured_output_response_format_kwarg(openai):
999999

10001000
langfuse.flush()
10011001

1002-
generation = wait_for_observations(
1003-
name=generation_name, type="GENERATION", expand_metadata="response_format"
1004-
)
1002+
generation = wait_for_observations(name=generation_name, type="GENERATION")
10051003

10061004
assert len(generation) != 0
10071005
assert generation[0].name == generation_name
10081006
assert generation[0].metadata["someKey"] == "someResponse"
1009-
assert generation[0].metadata["response_format"] == {
1010-
"type": "json_schema",
1011-
"json_schema": json_schema,
1012-
}
1007+
assert generation[0].metadata["response_format.type"] == "json_schema"
1008+
assert generation[0].metadata["response_format.json_schema.name"] == "math_response"
10131009

10141010
assert generation[0].input == [
10151011
{"role": "system", "content": "You are a helpful math tutor."},

0 commit comments

Comments
 (0)