Skip to content

Commit 4c5b5e6

Browse files
fix(media-manager): remove seen nodes post visit (#1639)
* fix: memory leak in OTEL traces * fix: memory leak in OTEL traces - address AI review * fix: memory leak in OTEL traces - apply fix after claude review --------- Co-authored-by: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com>
1 parent 41c5a5f commit 4c5b5e6

1 file changed

Lines changed: 60 additions & 8 deletions

File tree

‎langfuse/_task_manager/media_manager.py‎

Lines changed: 60 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,9 @@ def _find_and_process_media(
103103
max_levels = 10
104104

105105
def _process_data_recursively(data: Any, level: int) -> Any:
106-
if id(data) in seen or level > max_levels:
106+
if level > max_levels:
107107
return data
108108

109-
seen.add(id(data))
110-
111109
if isinstance(data, LangfuseMedia):
112110
self._process_media(
113111
media=data,
@@ -233,13 +231,67 @@ def _process_data_recursively(data: Any, level: int) -> Any:
233231
return copied
234232

235233
if isinstance(data, list):
236-
return [_process_data_recursively(item, level + 1) for item in data]
234+
if id(data) in seen:
235+
return data
236+
237+
seen.add(id(data))
238+
239+
try:
240+
return [_process_data_recursively(item, level + 1) for item in data]
241+
finally:
242+
seen.discard(id(data))
237243

238244
if isinstance(data, dict):
239-
return {
240-
key: _process_data_recursively(value, level + 1)
241-
for key, value in data.items()
242-
}
245+
if id(data) in seen:
246+
return data
247+
248+
seen.add(id(data))
249+
250+
try:
251+
return {
252+
key: _process_data_recursively(value, level + 1)
253+
for key, value in data.items()
254+
}
255+
finally:
256+
seen.discard(id(data))
257+
258+
if (
259+
hasattr(data, "__pydantic_fields__")
260+
and hasattr(data, "model_dump")
261+
and callable(data.model_dump)
262+
):
263+
# Pydantic v2 BaseModel
264+
if id(data) in seen:
265+
return data
266+
267+
seen.add(id(data))
268+
269+
try:
270+
try:
271+
dumped = data.model_dump()
272+
except Exception:
273+
return data
274+
275+
return _process_data_recursively(dumped, level + 1)
276+
finally:
277+
seen.discard(id(data))
278+
279+
if hasattr(data, "dict") and callable(data.dict) and hasattr(data, "__fields__"):
280+
# Pydantic v1 BaseModel
281+
if id(data) in seen:
282+
return data
283+
284+
seen.add(id(data))
285+
286+
try:
287+
try:
288+
dumped = data.dict()
289+
except Exception:
290+
return data
291+
292+
return _process_data_recursively(dumped, level + 1)
293+
finally:
294+
seen.discard(id(data))
243295

244296
return data
245297

0 commit comments

Comments
 (0)