Skip to content

Commit 7b427ba

Browse files
fix(serializer): correctly serialize float('-inf') as "-Infinity" (#1683)
* fix(serializer): correctly serialize float('-inf') as "-Infinity" * test(serializer): add test for float('-inf') serialization --------- Co-authored-by: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com>
1 parent 7ad529b commit 7b427ba

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎langfuse/_utils/serializer.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def _default_inner(self, obj: Any) -> Any:
7676
return "NaN"
7777

7878
if isinstance(obj, float) and math.isinf(obj):
79-
return "Infinity"
79+
return "-Infinity" if obj < 0 else "Infinity"
8080

8181
if isinstance(obj, (Exception, KeyboardInterrupt)):
8282
return f"{type(obj).__name__}: {str(obj)}"

‎tests/unit/test_serializer.py‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,12 @@ def test_none():
165165
assert serializer.encode(None) == "null"
166166

167167

168+
def test_infinity_floats():
169+
serializer = EventSerializer()
170+
assert serializer.encode(float("inf")) == '"Infinity"'
171+
assert serializer.encode(float("-inf")) == '"-Infinity"'
172+
173+
168174
def test_slots():
169175
class SlotClass:
170176
__slots__ = ["field"]

0 commit comments

Comments
 (0)