Skip to content

Commit 8d402a8

Browse files
committed
perf(span-processor): skip span_formatter when debug logging is off
1 parent e9fbe50 commit 8d402a8

2 files changed

Lines changed: 51 additions & 4 deletions

File tree

‎langfuse/_client/span_processor.py‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"""
1313

1414
import base64
15+
import logging
1516
import os
1617
import threading
1718
from typing import Callable, Dict, List, Optional, cast
@@ -218,9 +219,13 @@ def on_end(self, span: ReadableSpan) -> None:
218219
)
219220
return
220221

221-
langfuse_logger.debug(
222-
f"Trace: Processing span name='{span._name}' | Full details:\n{span_formatter(span)}"
223-
)
222+
# span_formatter serializes the full span; skip it unless DEBUG is on
223+
if langfuse_logger.isEnabledFor(logging.DEBUG):
224+
langfuse_logger.debug(
225+
"Trace: Processing span name='%s' | Full details:\n%s",
226+
span.name,
227+
span_formatter(span),
228+
)
224229

225230
super().on_end(span)
226231
finally:

‎tests/unit/test_span_processor.py‎

Lines changed: 43 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1+
import logging
12
from typing import Sequence
3+
from unittest.mock import patch
24

3-
from opentelemetry.sdk.trace import ReadableSpan
5+
import pytest
6+
from opentelemetry.sdk.trace import ReadableSpan, TracerProvider
47
from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult
58

9+
import langfuse._client.span_processor as span_processor_module
610
from langfuse._client.environment_variables import (
711
LANGFUSE_FLUSH_AT,
812
LANGFUSE_FLUSH_INTERVAL,
@@ -54,3 +58,41 @@ def test_span_processor_uses_env_flush_settings_when_constructor_omits_them(
5458
assert processor._batch_processor._schedule_delay_millis == 3250
5559
finally:
5660
processor.shutdown()
61+
62+
63+
@pytest.fixture
64+
def tracer_with_processor():
65+
processor = LangfuseSpanProcessor(
66+
public_key="pk-test",
67+
secret_key="sk-test",
68+
base_url="http://localhost:3000",
69+
span_exporter=NoOpSpanExporter(),
70+
)
71+
provider = TracerProvider()
72+
provider.add_span_processor(processor)
73+
yield provider.get_tracer("test-instrumentor")
74+
processor.shutdown()
75+
76+
77+
@pytest.mark.parametrize(
78+
("level", "expected_formatter_calls"),
79+
[(logging.WARNING, 0), (logging.DEBUG, 1)],
80+
)
81+
def test_on_end_formats_span_only_when_debug_enabled(
82+
caplog, tracer_with_processor, level, expected_formatter_calls
83+
):
84+
caplog.set_level(level, logger="langfuse")
85+
86+
with patch.object(
87+
span_processor_module, "span_formatter", return_value="{}"
88+
) as span_formatter:
89+
# gen_ai.* attribute makes the span pass the default export filter
90+
with tracer_with_processor.start_as_current_span(
91+
"llm-call", attributes={"gen_ai.system": "test"}
92+
):
93+
pass
94+
95+
assert span_formatter.call_count == expected_formatter_calls
96+
assert ("Processing span name='llm-call'" in caplog.text) == bool(
97+
expected_formatter_calls
98+
)

0 commit comments

Comments
 (0)