1010from datetime import datetime
1111
1212import pytest
13+ from opentelemetry import baggage , context
1314from opentelemetry .instrumentation .threading import ThreadingInstrumentor
1415
1516from langfuse import propagate_attributes
1617from langfuse ._client .attributes import LangfuseOtelSpanAttributes , _serialize
1718from langfuse ._client .constants import LANGFUSE_SDK_EXPERIMENT_ENVIRONMENT
1819from langfuse ._client .datasets import DatasetClient
20+ from langfuse ._client .propagation import _get_propagated_attributes_from_context
1921from langfuse .api import Dataset , DatasetItem , DatasetStatus
2022from tests .unit .test_otel import TestOTelBase
2123
@@ -3860,11 +3862,36 @@ def test_catalog_replaces_inherited_and_updates_current_span(
38603862 LangfuseOtelSpanAttributes .OBSERVATION_SKILLS_AVAILABLE ,
38613863 )
38623864
3863- def test_skills_never_use_baggage (self ):
3864- from opentelemetry import baggage , context
3865-
3866- from langfuse ._client .propagation import _get_propagated_attributes_from_context
3865+ @pytest .mark .parametrize ("skills" , [[{"name" : "refund" }], []])
3866+ @pytest .mark .parametrize ("set_on_update" , [False , True ])
3867+ def test_propagation_updates_current_observation_skills (
3868+ self , langfuse_client , memory_exporter , skills , set_on_update
3869+ ):
3870+ inherited = [{"name" : "child" }]
3871+ with propagate_attributes (skills_available = [{"name" : "outer" }]):
3872+ with langfuse_client .start_as_current_observation (
3873+ name = "parent" , available_skills = None if set_on_update else skills
3874+ ) as parent :
3875+ if set_on_update :
3876+ parent .update (available_skills = skills )
3877+ assert (
3878+ json .loads (
3879+ parent ._otel_span .attributes [
3880+ LangfuseOtelSpanAttributes .OBSERVATION_SKILLS_AVAILABLE
3881+ ]
3882+ )
3883+ == skills
3884+ )
3885+ with propagate_attributes (skills_available = inherited ):
3886+ langfuse_client .start_observation (name = "child" ).end ()
3887+ for name , expected in (("parent" , inherited ), ("child" , inherited )):
3888+ _assert_json_attribute (
3889+ self .get_span_by_name (memory_exporter , name ),
3890+ LangfuseOtelSpanAttributes .OBSERVATION_SKILLS_AVAILABLE ,
3891+ expected ,
3892+ )
38673893
3894+ def test_skills_baggage_is_read_but_not_written (self ):
38683895 with propagate_attributes (
38693896 skills_available = [{"name" : "local" }],
38703897 attach_skills = True ,
@@ -3874,16 +3901,9 @@ def test_skills_never_use_baggage(self):
38743901 incoming = baggage .set_baggage (
38753902 "langfuse_skills_available" , '[{"name":"remote"}]'
38763903 )
3877- incoming = baggage .set_baggage (
3878- "langfuse_attach_skills" , "true" , context = incoming
3879- )
3880- incoming = baggage .set_baggage (
3881- "langfuse_available_skills" , '[{"name":"legacy"}]' , context = incoming
3882- )
3883- incoming = baggage .set_baggage (
3884- "langfuse_attach_discovered_skills" , "true" , context = incoming
3885- )
3886- assert not _get_propagated_attributes_from_context (incoming )
3904+ assert _get_propagated_attributes_from_context (incoming ) == {
3905+ LangfuseOtelSpanAttributes .OBSERVATION_SKILLS_AVAILABLE : '[{"name":"remote"}]'
3906+ }
38873907 assert not _get_propagated_attributes_from_context (context .get_current ())
38883908
38893909 def test_invalid_serialization_keeps_outer_catalog (
0 commit comments