Skip to content

Commit b8952e3

Browse files
authored
fix: preserve zero sample rate (#1784)
1 parent 460fe1c commit b8952e3

2 files changed

Lines changed: 18 additions & 1 deletion

File tree

‎langfuse/_client/client.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,8 @@ def __init__(
351351
or get_common_release_envs()
352352
)
353353
self._project_id: Optional[str] = None
354-
sample_rate = sample_rate or float(os.environ.get(LANGFUSE_SAMPLE_RATE, 1.0))
354+
if sample_rate is None:
355+
sample_rate = float(os.environ.get(LANGFUSE_SAMPLE_RATE, 1.0))
355356
if not 0.0 <= sample_rate <= 1.0:
356357
raise ValueError(
357358
f"Sample rate must be between 0.0 and 1.0, got {sample_rate}"

‎tests/unit/test_initialization.py‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,22 @@ def test_default_base_url(self, cleanup_env_vars):
109109

110110
assert client._base_url == "https://cloud.langfuse.com"
111111

112+
def test_zero_sample_rate_parameter_is_preserved(
113+
self, cleanup_env_vars, monkeypatch
114+
):
115+
"""Test that an explicit zero sample rate overrides the environment."""
116+
monkeypatch.setenv("LANGFUSE_SAMPLE_RATE", "1.0")
117+
118+
client = Langfuse(
119+
public_key="test_pk_zero_sample_rate",
120+
secret_key="test_sk",
121+
tracing_enabled=False,
122+
sample_rate=0.0,
123+
)
124+
125+
assert client._resources is not None
126+
assert client._resources.sample_rate == 0.0
127+
112128
def test_base_url_env_var(self, cleanup_env_vars):
113129
"""Test that LANGFUSE_BASE_URL environment variable is used correctly."""
114130
os.environ["LANGFUSE_BASE_URL"] = "http://test-base-url.com"

0 commit comments

Comments
 (0)