Repository navigation
Commit e99cc02
fix(tracing): mask dict metadata per key when the mask function fails (#1956)
* fix(tracing): mask metadata per key when the mask function fails
When a custom mask function raised on dict metadata, the fallback string
was written to the bare langfuse.observation.metadata attribute. The
server parses that attribute as a JSON object, so the fallback was lost,
and nothing showed which keys had been masked. For dict metadata, write
the fallback under each key of the failed call instead, so it merges with
keys from earlier updates like any other update. Non-dict metadata, input
and output keep the plain-string fallback.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(tracing): apply mask to propagated trace metadata
propagate_attributes now applies the client's mask to each propagated
trace metadata value (keys are kept), on the raw value before
serialization and the 200 character check. If the mask raises, only
that value becomes the fallback string. The masked values are stored in
the context and baggage, so the current span, child spans, and outgoing
baggage all carry them. Matches langfuse-js #1003.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* docs(tracing): document which client's mask applies to propagated metadata
The mask for propagated trace metadata comes from the client for the
public key in the execution context, otherwise the only initialized
client. With several clients and no public key in context, or with no
client yet, propagated metadata is not masked. Document this and the
workarounds, and pin the behavior with a test.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* revert(tracing): do not mask propagated trace metadata
Propagated metadata is passed explicitly by the developer. Masking it
adds client-resolution ambiguity and baggage/length-limit ordering
complexity, and diverges from the JS SDK.
Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
* fix(tracing): keep string fallback when the mask fails on empty dict metadata
Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>1 parent f91a6aa commit e99cc02
3 files changed
Lines changed: 122 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| |||
706 | 707 | | |
707 | 708 | | |
708 | 709 | | |
709 | | - | |
| 710 | + | |
710 | 711 | | |
711 | 712 | | |
712 | | - | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
713 | 721 | | |
714 | 722 | | |
715 | 723 | | |
716 | 724 | | |
717 | 725 | | |
718 | 726 | | |
719 | 727 | | |
| 728 | + | |
720 | 729 | | |
721 | 730 | | |
722 | 731 | | |
| |||
733 | 742 | | |
734 | 743 | | |
735 | 744 | | |
736 | | - | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
737 | 752 | | |
738 | 753 | | |
739 | 754 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1980 | 1980 | | |
1981 | 1981 | | |
1982 | 1982 | | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
| 1996 | + | |
| 1997 | + | |
| 1998 | + | |
| 1999 | + | |
| 2000 | + | |
| 2001 | + | |
| 2002 | + | |
| 2003 | + | |
| 2004 | + | |
| 2005 | + | |
| 2006 | + | |
| 2007 | + | |
| 2008 | + | |
| 2009 | + | |
| 2010 | + | |
| 2011 | + | |
| 2012 | + | |
| 2013 | + | |
| 2014 | + | |
| 2015 | + | |
| 2016 | + | |
| 2017 | + | |
| 2018 | + | |
| 2019 | + | |
| 2020 | + | |
| 2021 | + | |
| 2022 | + | |
| 2023 | + | |
| 2024 | + | |
| 2025 | + | |
| 2026 | + | |
| 2027 | + | |
| 2028 | + | |
| 2029 | + | |
| 2030 | + | |
| 2031 | + | |
| 2032 | + | |
| 2033 | + | |
| 2034 | + | |
| 2035 | + | |
| 2036 | + | |
| 2037 | + | |
| 2038 | + | |
| 2039 | + | |
| 2040 | + | |
| 2041 | + | |
| 2042 | + | |
| 2043 | + | |
| 2044 | + | |
| 2045 | + | |
| 2046 | + | |
| 2047 | + | |
| 2048 | + | |
| 2049 | + | |
| 2050 | + | |
| 2051 | + | |
| 2052 | + | |
| 2053 | + | |
| 2054 | + | |
| 2055 | + | |
| 2056 | + | |
| 2057 | + | |
| 2058 | + | |
| 2059 | + | |
| 2060 | + | |
| 2061 | + | |
| 2062 | + | |
| 2063 | + | |
| 2064 | + | |
| 2065 | + | |
| 2066 | + | |
| 2067 | + | |
| 2068 | + | |
| 2069 | + | |
| 2070 | + | |
| 2071 | + | |
| 2072 | + | |
| 2073 | + | |
| 2074 | + | |
| 2075 | + | |
| 2076 | + | |
| 2077 | + | |
| 2078 | + | |
| 2079 | + | |
| 2080 | + | |
| 2081 | + | |
| 2082 | + | |
| 2083 | + | |
| 2084 | + | |
1983 | 2085 | | |
1984 | 2086 | | |
1985 | 2087 | | |
| |||
0 commit comments