From ee8488e18119f81f0ee3485a28dd8e34d7b7f736 Mon Sep 17 00:00:00 2001 From: moneebullah25 Date: Fri, 9 Oct 2026 06:16:00 -0400 Subject: [PATCH 1/2] fix(scores): drop score events above LANGFUSE_MAX_EVENT_SIZE_BYTES --- .../_task_manager/score_ingestion_consumer.py | 13 +++ tests/unit/test_score_ingestion_consumer.py | 94 +++++++++++++++++++ 2 files changed, 107 insertions(+) create mode 100644 tests/unit/test_score_ingestion_consumer.py diff --git a/langfuse/_task_manager/score_ingestion_consumer.py b/langfuse/_task_manager/score_ingestion_consumer.py index 1dce00f80..131fcfd3c 100644 --- a/langfuse/_task_manager/score_ingestion_consumer.py +++ b/langfuse/_task_manager/score_ingestion_consumer.py @@ -82,6 +82,19 @@ def _next(self) -> list: item_size = self._get_item_size(event) + if item_size > MAX_EVENT_SIZE_BYTES: + logger.error( + "Data error: Score event %s is %s bytes, exceeding the maximum " + "event size of %s bytes (LANGFUSE_MAX_EVENT_SIZE_BYTES). Score " + "will be dropped.", + event.get("id"), + item_size, + MAX_EVENT_SIZE_BYTES, + ) + self._ingestion_queue.task_done() + + continue + # check for serialization errors try: json.dumps(event, cls=EventSerializer) diff --git a/tests/unit/test_score_ingestion_consumer.py b/tests/unit/test_score_ingestion_consumer.py new file mode 100644 index 000000000..aaeceba62 --- /dev/null +++ b/tests/unit/test_score_ingestion_consumer.py @@ -0,0 +1,94 @@ +"""Tests for ScoreIngestionConsumer event size enforcement.""" + +from queue import Queue +from unittest.mock import MagicMock + +from pydantic import BaseModel + +from langfuse._task_manager import score_ingestion_consumer as sic +from langfuse._task_manager.score_ingestion_consumer import ScoreIngestionConsumer + + +def _consumer(queue: Queue, client: MagicMock, flush_at: int = 15): + return ScoreIngestionConsumer( + ingestion_queue=queue, + identifier=0, + client=client, + public_key="pk", + flush_at=flush_at, + flush_interval=0.1, + ) + + +def _event(event_id: str, comment: str) -> dict: + return {"id": event_id, "type": "score-create", "body": {"comment": comment}} + + +def test_oversized_event_is_dropped_and_others_are_sent(monkeypatch): + monkeypatch.setattr(sic, "MAX_EVENT_SIZE_BYTES", 1_000) + monkeypatch.setattr(sic, "logger", MagicMock()) + queue: Queue = Queue() + client = MagicMock() + # flush_at=2 ends the batch once both valid events are read, independent of timing + consumer = _consumer(queue, client, flush_at=2) + + queue.put(_event("a", "small")) + queue.put(_event("big", "x" * 5_000)) + queue.put(_event("c", "small")) + + consumer.upload() + + batch = client.batch_post.call_args.kwargs["batch"] + assert [e["id"] for e in batch] == ["a", "c"] + assert queue.unfinished_tasks == 0 + sic.logger.error.assert_called_once() + assert "big" in sic.logger.error.call_args.args + + +def test_only_oversized_event_posts_nothing(monkeypatch): + monkeypatch.setattr(sic, "MAX_EVENT_SIZE_BYTES", 1_000) + queue: Queue = Queue() + client = MagicMock() + consumer = _consumer(queue, client) + + queue.put(_event("big", "x" * 5_000)) + + consumer.upload() + + client.batch_post.assert_not_called() + assert queue.unfinished_tasks == 0 + + +def test_event_exactly_at_limit_is_sent(monkeypatch): + queue: Queue = Queue() + client = MagicMock() + consumer = _consumer(queue, client, flush_at=1) + event = _event("edge", "x" * 100) + size = consumer._get_item_size(event) + + monkeypatch.setattr(sic, "MAX_EVENT_SIZE_BYTES", size) + queue.put(event) + consumer.upload() + assert client.batch_post.call_count == 1 + + monkeypatch.setattr(sic, "MAX_EVENT_SIZE_BYTES", size - 1) + queue.put(_event("edge", "x" * 100)) + consumer.upload() + assert client.batch_post.call_count == 1 + + +def test_pydantic_body_is_measured_after_dump(monkeypatch): + class Body(BaseModel): + comment: str + + monkeypatch.setattr(sic, "MAX_EVENT_SIZE_BYTES", 1_000) + queue: Queue = Queue() + client = MagicMock() + consumer = _consumer(queue, client) + + queue.put({"id": "big", "type": "score-create", "body": Body(comment="x" * 5_000)}) + + consumer.upload() + + client.batch_post.assert_not_called() + assert queue.unfinished_tasks == 0 From 8b9feb62032efe252d8da88afd852bce5b397f94 Mon Sep 17 00:00:00 2001 From: moneebullah25 Date: Fri, 9 Oct 2026 10:42:08 -0400 Subject: [PATCH 2/2] test(scores): align score ingestion consumer tests with unit test conventions --- tests/unit/test_score_ingestion_consumer.py | 33 ++++++++++----------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/tests/unit/test_score_ingestion_consumer.py b/tests/unit/test_score_ingestion_consumer.py index aaeceba62..3981b98a8 100644 --- a/tests/unit/test_score_ingestion_consumer.py +++ b/tests/unit/test_score_ingestion_consumer.py @@ -1,7 +1,6 @@ -"""Tests for ScoreIngestionConsumer event size enforcement.""" - +import logging from queue import Queue -from unittest.mock import MagicMock +from unittest.mock import Mock from pydantic import BaseModel @@ -9,7 +8,7 @@ from langfuse._task_manager.score_ingestion_consumer import ScoreIngestionConsumer -def _consumer(queue: Queue, client: MagicMock, flush_at: int = 15): +def _consumer(queue: Queue, client: Mock, flush_at: int = 15): return ScoreIngestionConsumer( ingestion_queue=queue, identifier=0, @@ -24,11 +23,10 @@ def _event(event_id: str, comment: str) -> dict: return {"id": event_id, "type": "score-create", "body": {"comment": comment}} -def test_oversized_event_is_dropped_and_others_are_sent(monkeypatch): +def test_oversized_event_is_dropped_and_others_are_sent(monkeypatch, caplog): monkeypatch.setattr(sic, "MAX_EVENT_SIZE_BYTES", 1_000) - monkeypatch.setattr(sic, "logger", MagicMock()) - queue: Queue = Queue() - client = MagicMock() + queue = Queue() + client = Mock() # flush_at=2 ends the batch once both valid events are read, independent of timing consumer = _consumer(queue, client, flush_at=2) @@ -36,19 +34,20 @@ def test_oversized_event_is_dropped_and_others_are_sent(monkeypatch): queue.put(_event("big", "x" * 5_000)) queue.put(_event("c", "small")) - consumer.upload() + with caplog.at_level(logging.ERROR): + consumer.upload() batch = client.batch_post.call_args.kwargs["batch"] assert [e["id"] for e in batch] == ["a", "c"] assert queue.unfinished_tasks == 0 - sic.logger.error.assert_called_once() - assert "big" in sic.logger.error.call_args.args + assert len(caplog.records) == 1 + assert "Score event big is" in caplog.text def test_only_oversized_event_posts_nothing(monkeypatch): monkeypatch.setattr(sic, "MAX_EVENT_SIZE_BYTES", 1_000) - queue: Queue = Queue() - client = MagicMock() + queue = Queue() + client = Mock() consumer = _consumer(queue, client) queue.put(_event("big", "x" * 5_000)) @@ -60,8 +59,8 @@ def test_only_oversized_event_posts_nothing(monkeypatch): def test_event_exactly_at_limit_is_sent(monkeypatch): - queue: Queue = Queue() - client = MagicMock() + queue = Queue() + client = Mock() consumer = _consumer(queue, client, flush_at=1) event = _event("edge", "x" * 100) size = consumer._get_item_size(event) @@ -82,8 +81,8 @@ class Body(BaseModel): comment: str monkeypatch.setattr(sic, "MAX_EVENT_SIZE_BYTES", 1_000) - queue: Queue = Queue() - client = MagicMock() + queue = Queue() + client = Mock() consumer = _consumer(queue, client) queue.put({"id": "big", "type": "score-create", "body": Body(comment="x" * 5_000)})