Repository navigation
test: quarantine flaky live-provider tests - #2044
Merged
Merged
Conversation
Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
hassiebp
marked this pull request as ready for review
October 23, 2026 12:43
|
@claude review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Claude Code Review
No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Quarantines the three tests that fail intermittently in CI for reasons outside the SDK. They still run, but are marked as non-strict
xfail: a failure shows as XFAIL and a pass as XPASS, and neither can turn CI red.test_openai.py::test_audio_input_and_outputtest_langchain.py::test_multimodaltest_openai.py::test_base_64_image_inputHow the tests were picked. I parsed the failed test names from every CI log over the last three months (Jul 27 to Oct 22), then removed the noise:
A test only counts as flaky if it either passed and failed on the same commit, or failed in isolation across several unrelated branches.
Mechanism.
QUARANTINED_NODEIDSintests/conftest.pymirrors the existingSERIAL_E2E_NODEIDS. Quarantined tests also get a 60 s signal-based timeout. A hang then raises inside the test and counts as XFAIL, instead of the suite's thread-based timeout killing the pytest-xdist worker, which xdist reports as a hard failure.Considered but not quarantined:
test_decorators.pytests assertingtotal_cost > 0(test_nested_observationsand three siblings). They failed about 4% of the time until Oct 10 (9 of roughly 200 runs) and 0 of roughly 96 since. That looks fixed upstream in the Langfuse server, which CI pulls from HEAD. The test still races the server's asynchronous cost calculation, so it may need a better wait condition later.test_openai_function_call_streamed. Two OpenAI 500 errors on one commit, which could hit any provider test.scores_v3API change, theKeyError: 'response_format'SDK change,KeyError: 'context'in the media tests, and the retiredgpt-3.5-turbo-instructmodel.Type of change
Verification
I prototyped the mechanism in a scratch directory under xdist, with
--timeout-method=threadas in CI. A hanging test, a failing test and a passing test reported2 xfailed, 1 xpassedwith exit code 0.Checklist
code_review.md..env.templateif needed.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Quarantines three flaky live-provider tests without skipping them.
The supplied PR description by hassiebp explicitly acknowledges that suppressing failures in these three tests is intentional.
Reviews (1) · Last reviewed commit: "test: quarantine flaky live-provider tes..." · Reviewed by Greptile