Repository navigation
fix: preserve explicit parent for child events - #2045
Merged
Merged
Conversation
Collaborator
|
THanks a lot for your contribution, @AryanRG ! |
hassiebp
enabled auto-merge (squash)
October 23, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Child events created with
parent.start_observation(as_type="event")currently use the ambient span instead of the explicit parent. With no active span, they start a separate trace.Activate the explicit parent while creating the event, matching the existing child-span and
create_eventpaths. Added coverage for absent, matching and unrelated ambient spans, context restoration and event attributes.Type of change
Verification
The adjacent OTel/context tests also pass. No live-provider or e2e runs; the change is covered with the in-memory exporter.
Checklist
code_review.md.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Fixes child events so they use the explicit parent instead of the current active span.
No actionable issues found. Tests were reviewed but not run.
Reviews (1) · Last reviewed commit: "fix: preserve explicit parent for child ..." · Reviewed by Greptile