Repository navigation
docs(prompts): fix fetch_timeout_seconds unit in get_prompt docstring - #2087
Open
caiotheodoro wants to merge 1 commit into
Open
caiotheodoro wants to merge 1 commit into
caiotheodoro wants to merge 1 commit into
Conversation
The argument is passed to the API client as timeout_in_seconds and is applied as an httpx timeout in seconds, but the docstring said milliseconds.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Langfuse.get_promptdocumentsfetch_timeout_secondsas "The timeout in milliseconds". The value is passed straight torequest_options["timeout_in_seconds"]and used as the httpx timeout, so it is seconds. Following the docstring and passing5000gives a ~83 minute timeout.Checked against a local server that sleeps 4s before answering,
max_retries=0:Docstring-only change.
Type of change
Verification
Both pass with ruff 0.15.22.
mypy langfusereports 16 errors in my environment (14 missing langchain stubs, 2 inobserve.py), none in_client/client.py; not changed by a docstring edit.Checklist
code_review.md..env.templateif needed.Drafted with Claude Sonnet 5.5.


Confidence Score: 5/5
This docstring correction appears safe to merge.Summary
Corrects the
Langfuse.get_promptdocstring to describefetch_timeout_secondsin seconds rather than milliseconds.get_promptdocuments prompt fetch timeouts in seconds.Reviews (1) · Last reviewed commit: "docs(prompts): fix fetch_timeout_seconds..." · Reviewed by Greptile