Skip to content

docs: fix get_prompt fetch_timeout_seconds unit - #2100

Merged
hassiebp merged 1 commit into
langfuse:mainfrom
DavidTraina:docs/get-prompt-timeout-unit
Nov 5, 2026
Merged

hassiebp merged 1 commit into
langfuse:mainfrom
DavidTraina:docs/get-prompt-timeout-unit

Conversation

@DavidTraina

@DavidTraina DavidTraina commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

The get_prompt docstring described fetch_timeout_seconds as "The timeout in milliseconds". The value is passed to the API client as request_options["timeout_in_seconds"], so it is in seconds. This PR fixes the word.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Refactor
  • Documentation update
  • Tooling, CI, or repo maintenance

Verification

List the main commands you ran:

uv run --frozen ruff check .                                  # All checks passed!
uv run --frozen ruff format --check .                         # 593 files already formatted
uv run --frozen mypy langfuse --no-error-summary              # no issues
uv run --frozen pytest -n auto --dist worksteal tests/unit    # 1003 passed, 2 skipped

Checklist

  • I self-reviewed the diff using code_review.md.
  • I added or updated tests for behavior changes.
  • I updated docs, examples, or .env.template if needed.
  • I did not hand-edit generated files; if generated files changed, I used the upstream regeneration path.
  • I did not commit secrets or credentials.

RetriggerView in GreptileConfidence Score: 5/5

The PR is safe to merge.

Summary

Corrects the get_prompt docstring to describe fetch_timeout_seconds in seconds rather than milliseconds.

  • The prompt timeout docs now say the value is in seconds.

Reviews (1) · Last reviewed commit: "docs: fix get_prompt fetch_timeout_secon..." · Reviewed by Greptile

The docstring said milliseconds, but the value is passed to the API client
as timeout_in_seconds.
@CLAassistant

CLAassistant commented Nov 5, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@DavidTraina
DavidTraina marked this pull request as ready for review November 5, 2026 07:03

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@hassiebp
hassiebp merged commit 946240b into langfuse:main Nov 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants