Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
An expired prompt can start a background refresh while another operation invalidates or replaces its cache entry. If the old request finishes afterward, it can restore stale content or delete the newer entry after a 404.
Update or delete the cache entry only when it is still the same entry that scheduled the refresh. Foreground fetches retain their existing behavior.
Type of change
Verification
The regression exercises a delayed successful response and a delayed 404, both after invalidation and after replacement with a newer entry. Before the fix, the successful response overwrote the newer prompt and the 404 deleted it. The full unit suite passed with 1,019 passed and 2 skipped, using local test credentials.
Checklist
code_review.md.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Background refreshes now change the cache only when the entry that started the refresh is still current. Foreground fetches keep their existing behavior.
Reviews (2) · Last reviewed commit: "test(prompts): verify background refresh..." · Reviewed by Greptile