lint(api): enable Ruff F841 and resolve existing violations

Author: codex

api/.ruff.toml

@@ -64,7 +64,6 @@ ignore = [
     "E721",    # type-comparison
     "E722",    # bare-except
     "F821",    # undefined-name
-    "F841",    # unused-variable
     "FURB113", # repeated-append
     "FURB152", # math-constant
     "UP007",   # non-pep604-annotation

api/controllers/console/app/audio.py

@@ -443,7 +443,7 @@ def _get_text_to_speech_voices(*, tenant_id: str, language: str):
         raise CompletionRequestError(e.description)
     except ValueError as e:
         raise e
-    except Exception as e:
+    except Exception:
         logger.exception("Failed to handle get request to TextModesApi")
         raise InternalServerError()
 

api/controllers/console/app/completion.py

@@ -205,7 +205,7 @@ def post(self, req_data: CompletionMessagePayload, session: Session, current_use
             raise CompletionRequestError(e.description)
         except ValueError as e:
             raise e
-        except Exception as e:
+        except Exception:
             logger.exception("internal server error.")
             raise InternalServerError()
 
@@ -589,7 +589,7 @@ def _generate_chat_message(
         raise CompletionRequestError(e.description)
     except ValueError as e:
         raise e
-    except Exception as e:
+    except Exception:
         logger.exception("internal server error.")
         raise InternalServerError()
 

api/controllers/console/app/workflow.py

@@ -1885,7 +1885,7 @@ def post(self, current_user: Account, app_model: App, node_id: str):
                 files=files,
             )
             return jsonable_encoder(node_execution)
-        except Exception as e:
+        except Exception:
             logger.exception("Error running draft workflow trigger node")
             return jsonable_encoder(
                 {"status": "error", "error": "An unexpected error occurred while running the node."}

api/controllers/service_api/app/audio.py

@@ -152,7 +152,7 @@ def post(self, session: Session, app_model: App, end_user: EndUser):
             raise CompletionRequestError(e.description)
         except ValueError as e:
             raise e
-        except Exception as e:
+        except Exception:
             logger.exception("internal server error.")
             raise InternalServerError()
 
@@ -244,6 +244,6 @@ def post(self, payload: TextToAudioPayload, session: Session, app_model: App, en
             raise CompletionRequestError(e.description)
         except ValueError as e:
             raise e
-        except Exception as e:
+        except Exception:
             logger.exception("internal server error.")
             raise InternalServerError()

api/controllers/trigger/webhook.py

@@ -164,6 +164,6 @@ def handle_webhook_debug(webhook_id: str):
         raise NotFound(str(e))
     except RequestEntityTooLarge:
         raise
-    except Exception as e:
+    except Exception:
         logger.exception("Webhook debug processing failed for %s", webhook_id)
         return jsonify({"error": "Internal server error", "message": "An internal error has occurred."}), 500

api/controllers/web/audio.py

@@ -125,7 +125,7 @@ def post(self, session: Session, app_model: App, end_user: EndUser):
             raise CompletionRequestError(e.description)
         except ValueError as e:
             raise e
-        except Exception as e:
+        except Exception:
             logger.exception("Failed to handle post request to AudioApi")
             raise InternalServerError()
 
@@ -189,6 +189,6 @@ def post(self, payload: TextToAudioPayload, session: Session, app_model: App, en
             raise CompletionRequestError(e.description)
         except ValueError as e:
             raise e
-        except Exception as e:
+        except Exception:
             logger.exception("Failed to handle post request to TextApi")
             raise InternalServerError()

api/controllers/web/completion.py

@@ -161,7 +161,7 @@ def post(self, session: Session, app_model: App, end_user: EndUser):
             raise CompletionRequestError(e.description)
         except ValueError as e:
             raise e
-        except Exception as e:
+        except Exception:
             logger.exception("internal server error.")
             raise InternalServerError()
 
@@ -275,7 +275,7 @@ def post(self, session: Session, app_model: App, end_user: EndUser):
             raise CompletionRequestError(e.description)
         except ValueError as e:
             raise e
-        except Exception as e:
+        except Exception:
             logger.exception("internal server error.")
             raise InternalServerError()
 

api/core/tools/utils/model_invocation_utils.py

@@ -154,7 +154,7 @@ def invoke(
             raise InvokeModelError(f"Invoke bad request error: {e}")
         except InvokeConnectionError as e:
             raise InvokeModelError(f"Invoke connection error: {e}")
-        except InvokeAuthorizationError as e:
+        except InvokeAuthorizationError:
             raise InvokeModelError("Invoke authorization error")
         except InvokeServerUnavailableError as e:
             raise InvokeModelError(f"Invoke server unavailable error: {e}")

api/providers/trace/trace-weave/tests/unit_tests/weave_trace/test_weave_trace.py

@@ -265,7 +265,7 @@ def test_init_without_entity(self, mock_wandb, mock_weave):
         """Test __init__ initializes weave without entity prefix when entity is None."""
         mock_w, weave_client = mock_weave
         config = _make_weave_config(entity=None)
-        instance = WeaveDataTrace(config)
+        WeaveDataTrace(config)
 
         mock_w.init.assert_called_once_with(project_name="my-project")
 
@@ -318,7 +318,6 @@ def test_get_project_url_exception_raises(self, trace_instance, monkeypatch: pyt
         monkeypatch.setattr(trace_instance, "project_name", None)
         # Force an error by making string formatting fail
         # Simulate exception via property
-        original_entity = trace_instance.entity
         trace_instance.entity = None
         trace_instance.project_name = None
         url = trace_instance.get_project_url()