@@ -1,93 +1,15 @@
-# Rule Catalog — Architecture
+# Architecture review
 
-## Scope
-- Covers: controller/service/core-domain/libs/model layering, dependency direction, responsibility placement, observability-friendly flow.
+The [API agent guide](../../../../api/AGENTS.md) owns package boundaries. In particular, `api/core/` is migration-only: do not propose new files or extracted implementations there.
 
-## Rules
+## Transport and domain boundaries
 
-### Keep business logic out of controllers
-- Category: maintainability
-- Description: Controllers should parse input, call services, and return serialized responses. Business decisions inside controllers make behavior hard to reuse and test.
-- Suggested fix: Move domain/business logic into the service or core/domain layer. Keep controller handlers thin and orchestration-focused.
-- Example:
-  - Bad:
-    ```python
-    @bp.post("/apps/<app_id>/publish")
-    def publish_app(app_id: str):
-        payload = request.get_json() or {}
-        if payload.get("force") and current_user.role != "admin":
-            raise ValueError("only admin can force publish")
-        app = App.query.get(app_id)
-        app.status = "published"
-        db.session.commit()
-        return {"result": "ok"}
-    ```
-  - Good:
-    ```python
-    @bp.post("/apps/<app_id>/publish")
-    def publish_app(app_id: str):
-        payload = PublishRequest.model_validate(request.get_json() or {})
-        app_service.publish_app(app_id=app_id, force=payload.force, actor_id=current_user.id)
-        return {"result": "ok"}
-    ```
+Controllers own request parsing, service calls, and response serialization. Trace business decisions to their service or domain owner; flag controller policy when it duplicates or bypasses that owner. Move extracted behavior to an appropriate owner outside `core/`.
 
-### Preserve layer dependency direction
-- Category: best practices
-- Description: Controllers may depend on services, and services may depend on core/domain abstractions. Reversing this direction (for example, core importing controller/web modules) creates cycles and leaks transport concerns into domain code.
-- Suggested fix: Extract shared contracts into core/domain or service-level modules and make upper layers depend on lower, not the reverse.
-- Example:
-  - Bad:
-    ```python
-    # core/policy/publish_policy.py
-    from controllers.console.app import request_context
+## Dependency direction
 
+Transport layers may depend on services and domain contracts. Domain code must not import controller or request context. Pass validated actor, tenant, and resource data explicitly instead of reaching upward for it. Check existing owners and import-linter contracts before proposing a shared abstraction.
 
-    def can_publish() -> bool:
-        return request_context.current_user.is_admin
-    ```
-  - Good:
-    ```python
-    # core/policy/publish_policy.py
-    def can_publish(role: str) -> bool:
-        return role == "admin"
+## Business-agnostic libraries
 
-
-    # service layer adapts web/user context to domain input
-    allowed = can_publish(role=current_user.role)
-    ```
-
-### Keep libs business-agnostic
-- Category: maintainability
-- Description: Modules under `api/libs/` should remain reusable, business-agnostic building blocks. They must not encode product/domain-specific rules, workflow orchestration, or business decisions.
-- Suggested fix:
-  - If business logic appears in `api/libs/`, extract it into the appropriate `services/` or `core/` module and keep `libs` focused on generic, cross-cutting helpers.
-  - Keep `libs` dependencies clean: avoid importing service/controller/domain-specific modules into `api/libs/`.
-- Example:
-  - Bad:
-    ```python
-    # api/libs/conversation_filter.py
-    from services.conversation_service import ConversationService
-
-
-    def should_archive_conversation(conversation, tenant_id: str) -> bool:
-        # Domain policy and service dependency are leaking into libs.
-        service = ConversationService()
-        if service.has_paid_plan(tenant_id):
-            return conversation.idle_days > 90
-        return conversation.idle_days > 30
-    ```
-  - Good:
-    ```python
-    # api/libs/datetime_utils.py (business-agnostic helper)
-    def older_than_days(idle_days: int, threshold_days: int) -> bool:
-        return idle_days > threshold_days
-
-
-    # services/conversation_service.py (business logic stays in service/core)
-    from libs.datetime_utils import older_than_days
-
-
-    def should_archive_conversation(conversation, tenant_id: str) -> bool:
-        threshold_days = 90 if has_paid_plan(tenant_id) else 30
-        return older_than_days(conversation.idle_days, threshold_days)
-    ```
+`api/libs/` must not own product policy or orchestration. Flag service/controller dependencies and domain-specific decisions in library helpers. Move that behavior to its existing service or domain owner outside `core/`; retain only reusable infrastructure in `libs/`.
@@ -11,7 +11,7 @@
 - Description: If a table/model already has a repository abstraction, all reads/writes/queries for that table should use the existing repository. If no repository exists, introduce one only when complexity justifies it, such as large/high-volume tables, repeated complex query logic, or likely storage-strategy variation.
 - Suggested fix:
   - First check  `api/repositories`, `api/core/repositories`, and `api/extensions/*/repositories/` to verify whether the table/model already has a repository abstraction. If it exists, route all operations through it and add missing repository methods instead of bypassing it with ad-hoc SQLAlchemy access.
-  - If no repository exists, add one only when complexity warrants it (for example, repeated complex queries, large data domains, or multiple storage strategies), while preserving dependency direction (service/core depends on abstraction; infra provides implementation).
+  - If no repository exists, add one only when complexity warrants it (for example, repeated complex queries, large data domains, or multiple storage strategies). Follow `api/AGENTS.md`: put new abstractions and implementations outside migration-only `api/core/`, with services/domain code depending on abstractions and infrastructure providing implementations.
 - Example:
   - Bad:
     ```python
 
@@ -1,7 +1,7 @@
 # Development with devcontainer
 
 This project includes a devcontainer configuration that allows you to open the project in a container with a fully configured development environment.
-Both frontend and backend environments are initialized when the container is started.
+The create hook installs workspace JavaScript dependencies and `uv`; the start hook synchronizes backend dependencies. Follow the [backend setup](../api/README.md) and [frontend guide](../web/README.md) to configure environment files and start services.
 
 ## GitHub Codespaces
 
@@ -19,20 +19,6 @@ if you have VS Code installed, you can click the button above to open this proje
 
 You can learn more in the [Dev Containers documentation](https://code.visualstudio.com/docs/devcontainers/containers).
 
-## Pros of Devcontainer
-
-Unified Development Environment: By using devcontainers, you can ensure that all developers are developing in the same environment, reducing the occurrence of "it works on my machine" type of issues.
-
-Quick Start: New developers can set up their development environment in a few simple steps, without spending a lot of time on environment configuration.
-
-Isolation: Devcontainers isolate your project from your host operating system, reducing the chance of OS updates or other application installations impacting the development environment.
-
-## Cons of Devcontainer
-
-Learning Curve: For developers unfamiliar with Docker and VS Code, using devcontainers may be somewhat complex.
-
-Performance Impact: While usually minimal, programs running inside a devcontainer may be slightly slower than those running directly on the host.
-
 ## Troubleshooting
 
 if you see such error message when you open this project in codespaces:
 
@@ -9,3 +9,6 @@
 # Codegen output must stay byte-identical across platforms so
 # `pnpm tree:check` in CI does not trip on CRLF rewrites.
 *.generated.ts  text eol=lf
+
+# Skill scripts run on every platform, so keep LF line endings.
+/skills/**      text=auto eol=lf
@@ -57,13 +57,10 @@
 
 # Backend - RAG (Retrieval Augmented Generation)
 /api/core/rag/ @JohnJyong
+/api/services/knowledge/ @JohnJyong
 /api/services/rag_pipeline/ @JohnJyong
-/api/services/dataset_service.py @JohnJyong
 /api/services/knowledge_service.py @JohnJyong
-/api/services/external_knowledge_service.py @JohnJyong
 /api/services/hit_testing_service.py @JohnJyong
-/api/services/metadata_service.py @JohnJyong
-/api/services/vector_service.py @JohnJyong
 /api/services/entities/knowledge_entities/ @JohnJyong
 /api/services/entities/external_knowledge_entities/ @JohnJyong
 /api/controllers/console/datasets/ @JohnJyong
 
@@ -0,0 +1,104 @@
+const { execFile } = require('node:child_process')
+const { appendFile, mkdtemp, rm } = require('node:fs/promises')
+const os = require('node:os')
+const path = require('node:path')
+const { promisify } = require('node:util')
+const waitForBuild = require('./wait.cjs')
+
+const execFileAsync = promisify(execFile)
+
+async function downloadWebBuild({
+  env = process.env,
+  execute = execFileAsync,
+  webDir = path.resolve(__dirname, '../../../web'),
+} = {}) {
+  const repository = env.GITHUB_REPOSITORY
+  const runId = env.GITHUB_RUN_ID
+  const runAttempt = Number(env.GITHUB_RUN_ATTEMPT)
+  if (
+    !repository ||
+    !/^\d+$/.test(runId || '') ||
+    !Number.isInteger(runAttempt) ||
+    runAttempt < 1 ||
+    !env.GH_TOKEN
+  ) {
+    throw new Error(
+      'Downloading the Web build requires GITHUB_REPOSITORY, GITHUB_RUN_ID, GITHUB_RUN_ATTEMPT, and GH_TOKEN.',
+    )
+  }
+
+  const run = (command, args, timeout = 60_000) =>
+    execute(command, args, {
+      env,
+      timeout,
+      maxBuffer: 32 * 1024 * 1024,
+    })
+  const api = async (endpoint, paginate = false) => {
+    const { stdout } = await run('gh', [
+      'api',
+      endpoint,
+      ...(paginate ? ['--paginate', '--slurp'] : []),
+    ])
+    return JSON.parse(stdout)
+  }
+  const prefix = `repos/${repository}/actions`
+  let summary = ''
+  const artifactId = await waitForBuild({
+    github: {
+      rest: {
+        actions: { listJobsForWorkflowRunAttempt: 'jobs', listWorkflowRunArtifacts: 'artifacts' },
+      },
+      paginate: async (kind) => {
+        const endpoint =
+          kind === 'jobs'
+            ? `${prefix}/runs/${runId}/attempts/${runAttempt}/jobs?per_page=100`
+            : `${prefix}/runs/${runId}/artifacts?per_page=100`
+        const pages = await api(endpoint, true)
+        return pages.flatMap((page) => page[kind])
+      },
+    },
+    context: { repo: {}, runId },
+    core: {
+      info: console.log,
+      summary: {
+        addHeading(text) {
+          summary += `### ${text}\n\n`
+          return this
+        },
+        addRaw(text) {
+          summary += `${text}\n`
+          return this
+        },
+        async write() {
+          if (env.GITHUB_STEP_SUMMARY) await appendFile(env.GITHUB_STEP_SUMMARY, summary)
+        },
+      },
+    },
+    runAttempt,
+  })
+
+  const artifact = await api(`${prefix}/artifacts/${artifactId}`)
+  const directory = await mkdtemp(path.join(os.tmpdir(), 'dify-e2e-web-build-'))
+  try {
+    // Artifact names are immutable within a run. Use the name selected by wait.cjs,
+    // including its matching upload timestamp when only consumer jobs are rerun.
+    await run(
+      'gh',
+      ['run', 'download', runId, '--repo', repository, '--name', artifact.name, '--dir', directory],
+      300_000,
+    )
+    await run('tar', ['-xf', path.join(directory, 'e2e-web-build.tar'), '-C', webDir])
+    console.log(`Web build artifact ${artifactId} extracted and ready.`)
+  } finally {
+    await rm(directory, { force: true, recursive: true })
+  }
+}
+
+module.exports = downloadWebBuild
+
+if (require.main === module) {
+  downloadWebBuild().catch((error) => {
+    console.error(error)
+    process.exitCode = 1
+  })
+}