Skip to content

Commit 846fe44

Browse files
committed
Merge tracing CI fixes into deploy/agent
2 parents 6fb9f69 + 4f1a864 commit 846fe44

16 files changed

Lines changed: 26 additions & 33 deletions

‎api/controllers/console/agent/tracing.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
from services.app.agent_app_contracts import AgentAppNotFoundError
3939
from services.app.console_service import ConsoleAppNotFoundError
4040
from services.app_tracing_config_service import (
41+
AppTraceSettings,
4142
AppTracingConfigAlreadyExistsError,
4243
AppTracingConfigAppNotFoundError,
4344
AppTracingConfigConflictError,
@@ -48,7 +49,6 @@
4849
AppTracingConfigProviderUnavailableError,
4950
AppTracingConfigVerificationFailedError,
5051
)
51-
from services.entities.app_entities import AppTraceSettings
5252

5353
_EDIT_ROLES = frozenset({TenantAccountRole.OWNER, TenantAccountRole.ADMIN, TenantAccountRole.EDITOR})
5454

‎api/controllers/console/app/app.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
InvalidAppExportError,
7373
)
7474
from services.app_tracing_config_service import (
75+
AppTraceSettings,
7576
AppTracingConfigAppNotFoundError,
7677
AppTracingConfigConflictError,
7778
AppTracingConfigInvalidConfigurationError,
@@ -85,7 +86,6 @@
8586
AppListParams,
8687
AppListSortBy,
8788
AppRecord,
88-
AppTraceSettings,
8989
CopyAppParams,
9090
CreateAppParams,
9191
StarredAppListParams,

‎api/repositories/app/console_repository.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
from services.app.console_service import ConsoleAppNotFoundError, ConsoleApps
5050
from services.app.query_service import AppDescription, DiscoveryApps, RelatedApps
5151
from services.app_creation_records import create_installed_app_record, create_site_record
52+
from services.app_tracing_config_service import AppTraceSettings
5253
from services.entities.app_entities import (
5354
RECENT_APP_MODES,
5455
AppAgentBinding,
@@ -64,7 +65,6 @@
6465
AppRecord,
6566
AppReference,
6667
AppSummary,
67-
AppTraceSettings,
6868
AppUpdateArguments,
6969
CreateAppParams,
7070
RecentAppListItem,

‎api/repositories/app/tracing_config_repository.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
from models.model import App, TraceAppConfig
1313
from repositories.app.console_visibility import console_visible_condition
1414
from services.app_tracing_config_service import (
15+
AppTraceSettings,
1516
AppTracingConfigAppNotFoundError,
1617
AppTracingConfigConflictError,
1718
AppTracingConfigNotFoundError,
1819
AppTracingConfigRecord,
1920
AppTracingConfigStore,
2021
)
21-
from services.entities.app_entities import AppTraceSettings
2222

2323
_trace_settings = TypeAdapter(AppTraceSettings)
2424

‎api/services/agent_tracing_config_service.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
from typing import Any, Protocol
88

99
from machinery.context import RequestContext
10-
from services.app_tracing_config_service import AppTracingConfigRecord, AppTracingConfigService
11-
from services.entities.app_entities import AppTraceSettings
10+
from services.app_tracing_config_service import AppTraceSettings, AppTracingConfigRecord, AppTracingConfigService
1211

1312

1413
class AgentTracingOwner(Protocol):

‎api/services/app/console_service.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from models.model import AppMode
1212
from services.agent.errors import InvalidRosterAgentPackageError
1313
from services.agent.roster_package_entities import RosterAgentPackageExport
14+
from services.app_tracing_config_service import AppTraceSettings
1415
from services.entities.app_entities import (
1516
AppChange,
1617
AppCreationSettings,
@@ -21,7 +22,6 @@
2122
AppPage,
2223
AppRecord,
2324
AppReference,
24-
AppTraceSettings,
2525
CopyAppParams,
2626
CreateAppParams,
2727
ImportedAppPackage,

‎api/services/app_tracing_config_service.py‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,14 @@
55
from typing import Any, Protocol
66

77
from machinery.context import RequestContext
8-
from services.entities.app_entities import AppTraceSettings
8+
9+
10+
@dataclass(frozen=True, slots=True)
11+
class AppTraceSettings:
12+
enabled: bool = False
13+
tracing_provider: str | None = None
14+
capture_content: bool = False
15+
capture_agent: bool = True
916

1017

1118
@dataclass(frozen=True, slots=True)

‎api/services/entities/app_entities.py‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -225,14 +225,6 @@ class AppReference:
225225
bound_agent_id: str | None
226226

227227

228-
@dataclass(frozen=True, slots=True)
229-
class AppTraceSettings:
230-
enabled: bool = False
231-
tracing_provider: str | None = None
232-
capture_content: bool = False
233-
capture_agent: bool = True
234-
235-
236228
@dataclass(frozen=True, slots=True)
237229
class AppCreationSettings:
238230
app: dict[str, Any]

‎api/tests/unit_tests/controllers/console/agent/test_tracing.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
from machinery.context import RequestContext
2020
from models.account import Account, AccountStatus, TenantAccountRole
2121
from services.app.agent_app_contracts import AgentAppNotFoundError
22-
from services.app_tracing_config_service import AppTracingConfigRecord
23-
from services.entities.app_entities import AppTraceSettings
22+
from services.app_tracing_config_service import AppTraceSettings, AppTracingConfigRecord
2423
from tests.unit_tests.config_override import apply_config_overrides
2524

2625
AGENT_ID = UUID("1fbc2f02-f7e0-4910-9032-cbe5bf6c65d5")

‎api/tests/unit_tests/controllers/console/app/test_console_app_api.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
CreatorsPlatformDisabledError,
2828
InvalidAppExportError,
2929
)
30+
from services.app_tracing_config_service import AppTraceSettings
3031
from services.entities.app_entities import (
3132
AppExportOptions,
3233
AppListParams,
3334
AppPage,
3435
AppRecord,
35-
AppTraceSettings,
3636
CopyAppParams,
3737
CreateAppParams,
3838
StarredAppListParams,

0 commit comments

Comments
 (0)