Repository navigation
ci: enable Ruff UP007 - #44106
Merged
asukaminato0721 merged 5 commits intoOct 16, 2026
Merged
ci: enable Ruff UP007#44106
Conversation
asukaminato0721
requested review from
CourTeous33,
JohnJyong,
QuantumGhost,
WH-2099 and
laipz8200
as code owners
October 14, 2026 15:12
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-10-16 01:28:56.589144721 +0000
+++ /tmp/pyrefly_pr.txt 2026-10-16 01:28:47.841098896 +0000
@@ -3321,51 +3321,51 @@
ERROR Object of type `AudioContent | EmbeddedResource | ImageContent | ResourceLink | TextContent` has no attribute `text` [missing-attribute]
--> tests/unit_tests/core/mcp/server/test_streamable_http.py:390:16
ERROR `MockNotificationParams` is not assignable to upper bound `NotificationParams | dict[str, Any] | None` of type variable `NotificationParamsT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:52:24
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:51:24
ERROR `MockRequest` is not assignable to upper bound `ClientRequest | ServerRequest` of type variable `SendRequestT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:65:19
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:64:19
ERROR `MockNotification` is not assignable to upper bound `ClientNotification | ServerNotification` of type variable `SendNotificationT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:65:19
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:64:19
ERROR `MockResult` is not assignable to upper bound `ClientResult | ServerResult` of type variable `SendResultT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:65:19
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:64:19
ERROR `ReceiveRequest` is not assignable to upper bound `ClientRequest | ServerRequest` of type variable `ReceiveRequestT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:65:19
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:64:19
ERROR `ReceiveNotification` is not assignable to upper bound `ClientNotification | ServerNotification` of type variable `ReceiveNotificationT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:65:19
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:64:19
ERROR Argument `object` is not assignable to parameter `read_stream` with type `Queue[Unknown]` in function `core.mcp.session.base_session.BaseSession.__init__` [bad-argument-type]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:67:26
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:66:26
ERROR Argument `object` is not assignable to parameter `write_stream` with type `Queue[Unknown]` in function `core.mcp.session.base_session.BaseSession.__init__` [bad-argument-type]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:67:26
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:66:26
ERROR Argument `object` is not assignable to parameter `receive_request_type` with type `type[ReceiveRequest]` in function `core.mcp.session.base_session.BaseSession.__init__` [bad-argument-type]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:67:26
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:66:26
ERROR Argument `object` is not assignable to parameter `receive_notification_type` with type `type[ReceiveNotification]` in function `core.mcp.session.base_session.BaseSession.__init__` [bad-argument-type]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:67:26
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:66:26
ERROR Argument `object` is not assignable to parameter `read_timeout_seconds` with type `timedelta | None` in function `core.mcp.session.base_session.BaseSession.__init__` [bad-argument-type]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:67:26
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:66:26
ERROR Class member `MockSession._received_request` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:72:9
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:71:9
ERROR Class member `MockSession._received_notification` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:75:9
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:74:9
ERROR Class member `MockSession._handle_incoming` overrides parent class `BaseSession` in an inconsistent manner [bad-override-param-name]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:78:9
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:77:9
ERROR Class member `MockSession._handle_incoming` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:78:9
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:77:9
ERROR `ReceiveRequest` is not assignable to upper bound `ClientRequest | ServerRequest` of type variable `ReceiveRequestT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:94:33
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:93:33
ERROR `MockResult` is not assignable to upper bound `ClientResult | ServerResult` of type variable `SendResultT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:94:33
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:93:33
ERROR `ReceiveRequest` is not assignable to upper bound `ClientRequest | ServerRequest` of type variable `ReceiveRequestT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:121:33
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:120:33
ERROR `MockResult` is not assignable to upper bound `ClientResult | ServerResult` of type variable `SendResultT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:121:33
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:120:33
ERROR Object of class `NoneType` has no attribute `result` [missing-attribute]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:149:5
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:148:5
ERROR Object of class `NoneType` has no attribute `done` [missing-attribute]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:150:12
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:149:12
ERROR `ReceiveRequest` is not assignable to upper bound `ClientRequest | ServerRequest` of type variable `ReceiveRequestT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:596:26
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:595:26
ERROR `ReceiveNotification` is not assignable to upper bound `ClientNotification | ServerNotification` of type variable `ReceiveNotificationT` [bad-specialization]
- --> tests/unit_tests/core/mcp/session/test_base_session.py:596:26
+ --> tests/unit_tests/core/mcp/session/test_base_session.py:595:26
ERROR Argument `(c: Unknown, p: Unknown) -> None` is not assignable to parameter `sampling_callback` with type `SamplingFnT | None` in function `core.mcp.session.client_session.ClientSession.__init__` [bad-argument-type]
--> tests/unit_tests/core/mcp/session/test_client_session.py:97:54
ERROR Argument `(c: Unknown) -> None` is not assignable to parameter `list_roots_callback` with type `ListRootsFnT | None` in function `core.mcp.session.client_session.ClientSession.__init__` [bad-argument-type]
|
Contributor
Pyrefly Type Coverage
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44106 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 5304 5304
Lines 326595 326587 -8
Branches 63840 63840
=======================================
- Hits 290495 290491 -4
+ Misses 30903 30897 -6
- Partials 5197 5199 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
asukaminato0721
force-pushed
the
lint/ruff-up007
branch
from
October 14, 2026 15:55
a5e25eb to
0b55c21
Compare
hjlarry
previously approved these changes
Oct 15, 2026
hjlarry
previously approved these changes
Oct 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 16, 2026
asukaminato0721
enabled auto-merge
October 16, 2026 01:27
hjlarry
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Ruff UP007 for the backend and resolve its existing violations. This PR enables only this rule.
Validation:
make lintandmake type-checkpassed. The affected unit tests passed (26 tests).