ci: enable Ruff F841 by asukaminato0721 · Pull Request #44115 · langgenius/dify

asukaminato0721 · 2026-10-14T15:21:37Z

Enable Ruff F841 for the backend and resolve its existing violations. This PR enables only this rule.

Validation: make lint and make type-check passed. The affected unit tests passed (1821 tests).

github-actions · 2026-10-14T15:23:36Z

Pyrefly Diff

base → PR

--- /tmp/pyrefly_base.txt	2026-10-16 03:56:39.827296090 +0000
+++ /tmp/pyrefly_pr.txt	2026-10-16 03:56:30.787267782 +0000
@@ -719,13 +719,13 @@
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
    --> tests/test_containers_integration_tests/services/test_agent_service.py:135:38
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:567:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:564:24
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:802:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:793:24
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:965:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:953:24
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_agent_service.py:1006:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:993:24
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
    --> tests/test_containers_integration_tests/services/test_annotation_service.py:103:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
@@ -831,77 +831,77 @@
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
    --> tests/test_containers_integration_tests/services/test_app_service.py:447:13
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:500:43
+   --> tests/test_containers_integration_tests/services/test_app_service.py:500:32
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:502:13
+   --> tests/test_containers_integration_tests/services/test_app_service.py:501:32
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:507:25
+   --> tests/test_containers_integration_tests/services/test_app_service.py:505:25
 ERROR Object of class `NoneType` has no attribute `items` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:509:20
+   --> tests/test_containers_integration_tests/services/test_app_service.py:507:20
 ERROR Cannot index into `object` [bad-index]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:510:16
+   --> tests/test_containers_integration_tests/services/test_app_service.py:508:16
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:514:25
+   --> tests/test_containers_integration_tests/services/test_app_service.py:512:25
 ERROR Object of class `NoneType` has no attribute `items` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:516:20
+   --> tests/test_containers_integration_tests/services/test_app_service.py:514:20
 ERROR Cannot index into `object` [bad-index]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:517:26
+   --> tests/test_containers_integration_tests/services/test_app_service.py:515:26
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:522:13
+   --> tests/test_containers_integration_tests/services/test_app_service.py:520:13
 ERROR Object of class `NoneType` has no attribute `items` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:526:20
+   --> tests/test_containers_integration_tests/services/test_app_service.py:524:20
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:564:32
+   --> tests/test_containers_integration_tests/services/test_app_service.py:562:32
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:573:32
+   --> tests/test_containers_integration_tests/services/test_app_service.py:571:32
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:577:13
+   --> tests/test_containers_integration_tests/services/test_app_service.py:575:13
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:619:38
+   --> tests/test_containers_integration_tests/services/test_app_service.py:617:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:628:72
+   --> tests/test_containers_integration_tests/services/test_app_service.py:626:72
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:632:24
+   --> tests/test_containers_integration_tests/services/test_app_service.py:630:24
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:646:72
+   --> tests/test_containers_integration_tests/services/test_app_service.py:644:72
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:682:38
+   --> tests/test_containers_integration_tests/services/test_app_service.py:680:38
 ERROR Argument `dict[str, bool | str]` is not assignable to parameter `args` with type `AppService.ArgsDict` in function `services.app_service.AppService.update_app` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:706:55
+   --> tests/test_containers_integration_tests/services/test_app_service.py:699:55
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:743:13
+   --> tests/test_containers_integration_tests/services/test_app_service.py:736:13
 ERROR Missing required key `max_active_requests` for TypedDict `ArgsDict` [bad-typed-dict-key]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:763:17
+   --> tests/test_containers_integration_tests/services/test_app_service.py:756:17
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:798:13
+   --> tests/test_containers_integration_tests/services/test_app_service.py:791:13
 ERROR Missing required key `max_active_requests` for TypedDict `ArgsDict` [bad-typed-dict-key]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:819:21
+   --> tests/test_containers_integration_tests/services/test_app_service.py:812:21
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:862:38
+   --> tests/test_containers_integration_tests/services/test_app_service.py:855:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:920:38
+   --> tests/test_containers_integration_tests/services/test_app_service.py:912:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:933:70
+   --> tests/test_containers_integration_tests/services/test_app_service.py:925:70
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:972:38
+   --> tests/test_containers_integration_tests/services/test_app_service.py:964:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_app_service.py:993:70
+   --> tests/test_containers_integration_tests/services/test_app_service.py:985:70
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-    --> tests/test_containers_integration_tests/services/test_app_service.py:1061:13
+    --> tests/test_containers_integration_tests/services/test_app_service.py:1053:13
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-    --> tests/test_containers_integration_tests/services/test_app_service.py:1077:13
+    --> tests/test_containers_integration_tests/services/test_app_service.py:1069:13
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-    --> tests/test_containers_integration_tests/services/test_app_service.py:1093:13
+    --> tests/test_containers_integration_tests/services/test_app_service.py:1085:13
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-    --> tests/test_containers_integration_tests/services/test_app_service.py:1110:13
+    --> tests/test_containers_integration_tests/services/test_app_service.py:1102:13
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-    --> tests/test_containers_integration_tests/services/test_app_service.py:1127:25
+    --> tests/test_containers_integration_tests/services/test_app_service.py:1119:25
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-    --> tests/test_containers_integration_tests/services/test_app_service.py:1137:13
+    --> tests/test_containers_integration_tests/services/test_app_service.py:1129:13
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-    --> tests/test_containers_integration_tests/services/test_app_service.py:1149:13
+    --> tests/test_containers_integration_tests/services/test_app_service.py:1141:13
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-    --> tests/test_containers_integration_tests/services/test_app_service.py:1160:25
+    --> tests/test_containers_integration_tests/services/test_app_service.py:1152:25
 ERROR Argument `Literal['owner']` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_conversation_service_variables.py:46:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
@@ -1023,25 +1023,25 @@
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:93:20
 ERROR Argument `Literal['custom']` is not assignable to parameter `provider_type` with type `ProviderType | SQLCoreOperations[ProviderType]` in function `models.provider.Provider.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:133:27
+   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:132:27
 ERROR Argument `Literal['llm']` is not assignable to parameter `model_type` with type `ModelType | SQLCoreOperations[ModelType]` in function `models.provider.ProviderModelSetting.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:144:24
+   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:143:24
 ERROR Argument `Literal['llm']` is not assignable to parameter `model_type` with type `ModelType | SQLCoreOperations[ModelType]` in function `models.provider.LoadBalancingModelConfig.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:301:24
+   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:300:24
 ERROR Argument `Literal['llm']` is not assignable to parameter `model_type` with type `ModelType | SQLCoreOperations[ModelType]` in function `models.provider.LoadBalancingModelConfig.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:428:24
+   --> tests/test_containers_integration_tests/services/test_model_load_balancing_service.py:427:24
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:55:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:64:20
 ERROR Argument `Literal['custom']` is not assignable to parameter `provider_type` with type `ProviderType | SQLCoreOperations[ProviderType]` in function `models.provider.Provider.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:108:27
+   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:107:27
 ERROR Argument `Literal['free']` is not assignable to parameter `quota_type` with type `ProviderQuotaType | SQLCoreOperations[ProviderQuotaType | None] | None` in function `models.provider.Provider.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:110:24
+   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:109:24
 ERROR Argument `str` is not assignable to parameter `model_type` with type `ModelType | SQLCoreOperations[ModelType]` in function `models.provider.ProviderModel.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:149:24
+   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:147:24
 ERROR Argument `str` is not assignable to parameter `model_type` with type `ModelType | SQLCoreOperations[ModelType]` in function `models.provider.ProviderModelSetting.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:187:24
+   --> tests/test_containers_integration_tests/services/test_model_provider_service.py:184:24
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_schedule_service.py:30:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
@@ -1067,11 +1067,11 @@
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
    --> tests/test_containers_integration_tests/services/test_workflow_app_service.py:125:38
 ERROR Object of class `NoneType` has no attribute `status` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_workflow_app_service.py:573:16
+   --> tests/test_containers_integration_tests/services/test_workflow_app_service.py:572:16
 ERROR Object of class `NoneType` has no attribute `status` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_workflow_app_service.py:580:16
+   --> tests/test_containers_integration_tests/services/test_workflow_app_service.py:579:16
 ERROR Object of class `NoneType` has no attribute `status` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_workflow_app_service.py:587:16
+   --> tests/test_containers_integration_tests/services/test_workflow_app_service.py:586:16
 ERROR Argument `Literal['workflow']` is not assignable to parameter `value` with type `AppMode | SQLCoreOperations[AppMode]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_workflow_draft_variable_service.py:72:20
 ERROR Argument `Literal['emoji']` is not assignable to parameter `value` with type `IconType | SQLCoreOperations[IconType | None] | None` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
@@ -1079,27 +1079,27 @@
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
    --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:119:38
 ERROR Argument `float` is not assignable to parameter `value` with type `Decimal | SQLCoreOperations[Decimal]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:208:38
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:207:38
 ERROR Argument `float` is not assignable to parameter `value` with type `Decimal | SQLCoreOperations[Decimal]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:209:37
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:208:37
 ERROR Argument `float` is not assignable to parameter `value` with type `Decimal | SQLCoreOperations[Decimal]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:210:38
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:209:38
 ERROR Argument `float` is not assignable to parameter `value` with type `Decimal | SQLCoreOperations[Decimal]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:211:37
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:210:37
 ERROR Argument `Literal['normal']` is not assignable to parameter `value` with type `MessageStatus | SQLCoreOperations[MessageStatus]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:213:26
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:212:26
 ERROR Argument `dict[str, int | None]` is not assignable to parameter `args` with type `WorkflowRunListArgs` in function `services.workflow_run_service.WorkflowRunService.get_paginate_workflow_runs` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:254:18
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:253:18
 ERROR Argument `dict[Unknown, Unknown]` is not assignable to parameter `args` with type `WorkflowRunListArgs` in function `services.workflow_run_service.WorkflowRunService.get_paginate_workflow_runs` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:347:18
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:346:18
 ERROR Argument `dict[str, int | None]` is not assignable to parameter `args` with type `WorkflowRunListArgs` in function `services.workflow_run_service.WorkflowRunService.get_paginate_advanced_chat_workflow_runs` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:398:18
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:397:18
 ERROR Object of class `NoneType` has no attribute `startswith` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:579:20
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:578:20
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:617:38
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:616:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:669:38
+   --> tests/test_containers_integration_tests/services/test_workflow_run_service.py:668:38
 ERROR Argument `str | None` is not assignable to parameter `value` with type `SQLCoreOperations[str] | str` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_workflow_service.py:81:21
 ERROR Argument `Literal['single-step']` is not assignable to parameter `value` with type `SQLCoreOperations[WorkflowNodeExecutionTriggeredFrom] | WorkflowNodeExecutionTriggeredFrom` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
@@ -1107,15 +1107,15 @@
 ERROR Argument `Literal['succeeded']` is not assignable to parameter `value` with type `SQLCoreOperations[WorkflowNodeExecutionStatus] | WorkflowNodeExecutionStatus` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
    --> tests/test_containers_integration_tests/services/test_workflow_service.py:186:33
 ERROR Argument `Literal['invalid_mode']` is not assignable to parameter `value` with type `AppMode | SQLCoreOperations[AppMode]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1314:20
+    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1313:20
 ERROR `Literal['total_tokens']` is not assignable to dict key type `WorkflowNodeExecutionMetadataKey` [bad-assignment]
-    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1663:27
+    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1661:27
 ERROR Argument `() -> tuple[_ExecutedNode, Generator[NodeRunSucceededEvent, Unknown]]` is not assignable to parameter `invoke_node_fn` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.workflow_service.WorkflowService._handle_single_step_result` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1685:28
+    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1683:28
 ERROR Argument `() -> tuple[_ExecutedNode, Generator[NodeRunFailedEvent, Unknown]]` is not assignable to parameter `invoke_node_fn` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.workflow_service.WorkflowService._handle_single_step_result` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1753:28
+    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1751:28
 ERROR Argument `() -> tuple[_ExecutedNode, Generator[NodeRunFailedEvent, Unknown]]` is not assignable to parameter `invoke_node_fn` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.workflow_service.WorkflowService._handle_single_step_result` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1820:28
+    --> tests/test_containers_integration_tests/services/test_workflow_service.py:1818:28
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/tools/test_mcp_tools_manage_service.py:63:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
@@ -3303,11 +3303,11 @@
 ERROR Argument `list[bytes]` is not assignable to parameter `event_source` with type `Iterator[bytes]` in function `sseclient.SSEClient.__init__` [bad-argument-type]
    --> tests/unit_tests/core/mcp/client/test_sse.py:743:33
 ERROR Object of class `JSONRPCNotification` has no attribute `id` [missing-attribute]
-   --> tests/unit_tests/core/mcp/client/test_streamable_http.py:613:16
+   --> tests/unit_tests/core/mcp/client/test_streamable_http.py:609:16
 ERROR Object of class `JSONRPCNotification` has no attribute `id` [missing-attribute]
-    --> tests/unit_tests/core/mcp/client/test_streamable_http.py:1173:16
+    --> tests/unit_tests/core/mcp/client/test_streamable_http.py:1169:16
 ERROR `Literal['not-a-client-metadata']` is not assignable to attribute `metadata` with type `ClientMessageMetadata | ServerMessageMetadata | None` [bad-assignment]
-    --> tests/unit_tests/core/mcp/client/test_streamable_http.py:1256:24
+    --> tests/unit_tests/core/mcp/client/test_streamable_http.py:1252:24
 ERROR Object of type `AudioContent | EmbeddedResource | ImageContent | ResourceLink | TextContent` has no attribute `text` [missing-attribute]
    --> tests/unit_tests/core/mcp/server/test_streamable_http.py:371:16
 ERROR Object of type `AudioContent | EmbeddedResource | ImageContent | ResourceLink | TextContent` has no attribute `text` [missing-attribute]
@@ -3355,9 +3355,9 @@
 ERROR Object of class `NoneType` has no attribute `done` [missing-attribute]
    --> tests/unit_tests/core/mcp/session/test_base_session.py:149:12
 ERROR `ReceiveRequest` is not assignable to upper bound `ClientRequest | ServerRequest` of type variable `ReceiveRequestT` [bad-specialization]
-   --> tests/unit_tests/core/mcp/session/test_base_session.py:595:26
+   --> tests/unit_tests/core/mcp/session/test_base_session.py:594:26
 ERROR `ReceiveNotification` is not assignable to upper bound `ClientNotification | ServerNotification` of type variable `ReceiveNotificationT` [bad-specialization]
-   --> tests/unit_tests/core/mcp/session/test_base_session.py:595:26
+   --> tests/unit_tests/core/mcp/session/test_base_session.py:594:26
 ERROR Argument `(c: Unknown, p: Unknown) -> None` is not assignable to parameter `sampling_callback` with type `SamplingFnT | None` in function `core.mcp.session.client_session.ClientSession.__init__` [bad-argument-type]
   --> tests/unit_tests/core/mcp/session/test_client_session.py:97:54
 ERROR Argument `(c: Unknown) -> None` is not assignable to parameter `list_roots_callback` with type `ListRootsFnT | None` in function `core.mcp.session.client_session.ClientSession.__init__` [bad-argument-type]
@@ -4011,13 +4011,13 @@
 ERROR Argument `str` is not assignable to parameter `mode` with type `Literal['advanced-chat', 'auto', 'workflow']` in function `core.workflow.generator.runner.WorkflowGenerator.generate_workflow_graph` [bad-argument-type]
     --> tests/unit_tests/core/workflow/generator/test_runner.py:4682:103
 ERROR Class member `MockGenerator._collect_refs_in_data` overrides parent class `WorkflowGenerator` in an inconsistent manner [bad-override-param-name]
-   --> tests/unit_tests/core/workflow/generator/test_runner_missing.py:112:13
+   --> tests/unit_tests/core/workflow/generator/test_runner_missing.py:108:13
 ERROR Class member `MockGenerator._collect_refs_in_data` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
-   --> tests/unit_tests/core/workflow/generator/test_runner_missing.py:112:13
+   --> tests/unit_tests/core/workflow/generator/test_runner_missing.py:108:13
 ERROR Argument `dict[str, list[dict[str, str]]]` is not assignable to parameter `graph` with type `GraphDict` in function `core.workflow.generator.runner.WorkflowGenerator._collect_edge_cycle_errors` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/generator/test_runner_missing.py:124:65
+   --> tests/unit_tests/core/workflow/generator/test_runner_missing.py:119:65
 ERROR Argument `dict[str, list[dict[str, str | dict[str, str]]] | list[Unknown]]` is not assignable to parameter `graph` with type `GraphDict` in function `core.workflow.generator.runner.WorkflowGenerator._validate_structure` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/generator/test_runner_missing.py:185:58
+   --> tests/unit_tests/core/workflow/generator/test_runner_missing.py:176:49
 ERROR Cannot extend final class `DifyNodeFactory` [invalid-inheritance]
   --> tests/unit_tests/core/workflow/graph_engine/test_mock_factory.py:38:23
 ERROR Class member `MockNodeFactory.create_node` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
@@ -5109,11 +5109,11 @@
 ERROR Object of class `NoneType` has no attribute `loader` [missing-attribute]
   --> tests/unit_tests/migrations/test_uuidv7_pg18_migration.py:32:5
 ERROR TypedDict `TenantCustomConfigDict` does not have key `feature1` [bad-typed-dict-key]
-   --> tests/unit_tests/models/test_account_models.py:658:23
+   --> tests/unit_tests/models/test_account_models.py:657:23
 ERROR TypedDict `TenantCustomConfigDict` does not have key `feature2` [bad-typed-dict-key]
-   --> tests/unit_tests/models/test_account_models.py:659:23
+   --> tests/unit_tests/models/test_account_models.py:658:23
 ERROR Argument `dict[str, bool | str]` is not assignable to parameter `value` with type `TenantCustomConfigDict` in function `models.account.Tenant.custom_config_dict` [bad-argument-type]
-   --> tests/unit_tests/models/test_account_models.py:680:37
+   --> tests/unit_tests/models/test_account_models.py:679:37
 ERROR Object of class `NoneType` has no attribute `mode` [missing-attribute]
    --> tests/unit_tests/models/test_app_models.py:217:16
 ERROR Object of class `FromClause` has no attribute `insert` [missing-attribute]
@@ -5131,7 +5131,7 @@
 ERROR Argument `None` is not assignable to parameter `value` with type `SQLCoreOperations[str] | str` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
    --> tests/unit_tests/models/test_tool_models.py:603:47
 ERROR Object of class `WorkflowDraftVariable` has no attribute `_WorkflowDraftVariable__value` [missing-attribute]
-   --> tests/unit_tests/models/test_workflow.py:445:9
+   --> tests/unit_tests/models/test_workflow.py:442:9
 ERROR Class member `TestAliyunOss.setup_method` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
   --> tests/unit_tests/oss/aliyun_oss/aliyun_oss/test_aliyun_oss.py:18:9
 ERROR Class member `TestBaiduObs.setup_method` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
@@ -5195,7 +5195,7 @@
 ERROR Object of class `NoneType` has no attribute `node_job_config_dict` [missing-attribute]
    --> tests/unit_tests/services/agent/test_workflow_publish_service.py:577:49
 ERROR Object of class `Flask` has no attribute `login_manager` [missing-attribute]
-   --> tests/unit_tests/services/controller_api.py:830:9
+   --> tests/unit_tests/services/controller_api.py:828:9
 ERROR Class member `StubResolver.resolve` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
    --> tests/unit_tests/services/data_migration/test_import_service.py:256:13
 ERROR Class member `CapturingImportService._import_workflows` overrides parent class `MigrationImportService` in an inconsistent manner [bad-override]
@@ -5305,13 +5305,13 @@
 ERROR Argument `dict[str, list[dict[str, dict[str, str | dict[str, str] | dict[str, int | str]]]]]` is not assignable to parameter `graph` with type `dict[str, object] | None` in function `_make_workflow` [bad-argument-type]
    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:623:67
 ERROR Argument `() -> tuple[SimpleNamespace, Generator[NodeRunFailedEvent, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1462:16
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1459:16
 ERROR Argument `() -> tuple[SimpleNamespace, Generator[object, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1866:20
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1862:20
 ERROR Argument `() -> tuple[SimpleNamespace, Iterator[NodeRunFailedEvent]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1886:16
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1882:16
 ERROR Argument `() -> tuple[SimpleNamespace, Iterator[NodeRunFailedEvent]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1906:16
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1902:16
 ERROR No matching overload found for function `typing.MutableMapping.update` called with arguments: (dict[str, object]) [no-matching-overload]
   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_transform_service.py:29:18
 ERROR No matching overload found for function `typing.MutableMapping.update` called with arguments: (dict[str, object]) [no-matching-overload]

github-actions · 2026-10-14T15:25:06Z

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	75.04%	75.04%	+0.00%
Strict coverage	74.71%	74.71%	+0.00%
Typed symbols	62,005	62,014	+9
Untyped symbols	20,718	20,718	0
Modules	3797	3797	0

codecov · 2026-10-14T15:27:29Z

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.99%. Comparing base (1028543) to head (706f1a2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
api/controllers/console/app/completion.py	50.00%	1 Missing ⚠️
api/controllers/console/app/workflow.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #44115      +/-   ##
==========================================
+ Coverage   88.96%   88.99%   +0.02%     
==========================================
  Files        5305     5352      +47     
  Lines      326631   332568    +5937     
  Branches    63844    66004    +2160     
==========================================
+ Hits       290576   295953    +5377     
- Misses      30862    31421     +559     
- Partials     5193     5194       +1

Flag	Coverage Δ
api	`88.58% <89.47%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

asukaminato0721 requested review from CourTeous33, JohnJyong, QuantumGhost and laipz8200 as code owners October 14, 2026 15:21

github-actions Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 14, 2026

ghfind-review Bot added the review: high ghfind author score; see https://ghfind.com label Oct 14, 2026

hjlarry reviewed Oct 15, 2026

View reviewed changes

Comment thread api/tests/test_containers_integration_tests/services/test_model_load_balancing_service.py Outdated

codex added 2 commits October 15, 2026 12:48

lint(api): enable Ruff F841 and resolve existing violations

eb43206

clean

71d6bcc

asukaminato0721 force-pushed the lint/ruff-f841 branch from 70ee022 to 71d6bcc Compare October 15, 2026 03:49

asukaminato0721 requested a review from hjlarry October 15, 2026 03:49

asukaminato0721 enabled auto-merge October 15, 2026 03:50

[autofix.ci] apply automated fixes

e2335b5

hjlarry reviewed Oct 15, 2026

View reviewed changes

codex added 2 commits October 15, 2026 13:16

clean

9032b4e

.

b1a870d

asukaminato0721 requested a review from hjlarry October 15, 2026 04:18

codex added 2 commits October 15, 2026 13:20

.

42aa08f

fix format

7afc78c

asukaminato0721 requested a review from WH-2099 as a code owner October 15, 2026 04:31

autofix-ci Bot and others added 2 commits October 15, 2026 04:34

[autofix.ci] apply automated fixes

38b6263

Merge branch 'main' into lint/ruff-f841

beec475

hjlarry previously approved these changes Oct 16, 2026

View reviewed changes

asukaminato0721 disabled auto-merge October 16, 2026 01:17

asukaminato0721 enabled auto-merge October 16, 2026 01:17

Merge branch 'main' into lint/ruff-f841

465d2b9

asukaminato0721 dismissed hjlarry’s stale review via 465d2b9 October 16, 2026 01:51

hjlarry previously approved these changes Oct 16, 2026

View reviewed changes

Merge branch 'main' into lint/ruff-f841

46ad13d

asukaminato0721 dismissed hjlarry’s stale review via 46ad13d October 16, 2026 03:38

test: restore calls required by F841 cleanup tests

4fba652

asukaminato0721 requested a review from hjlarry October 16, 2026 03:48

test: cover controller errors changed by F841 cleanup

706f1a2

Navigation Menu

Repository navigation

ci: enable Ruff F841 - #44115

ci: enable Ruff F841#44115
asukaminato0721 wants to merge 13 commits into
langgenius:mainfrom
asukaminato0721:lint/ruff-f841

asukaminato0721 commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

asukaminato0721 commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pyrefly Diff

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pyrefly Type Coverage

Uh oh!

codecov Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

codecov Bot commented Oct 14, 2026 •

edited

Loading