Integration of my test fixes with new logger - #493
Open
skylerreid wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy/pasting my old PR description and oscar's, since this is just those 2 squashed together.
Non-breaking change. Switched @test result["termination_status"] == LOCALLY_SOLVED to @test result["primal_status"] == FEASIBLE_POINT. This fixes the issue where all versions of Julia can get to an objective that looks reasonable, but the solver is not convinced that the solution is optimal (often resulting in OTHER_ERROR or similar).
Added CASE3B and CASE3U as exported constants in PMD. This lets the user call case = parse_file(CASE3B), for example.
Oscar's description:
I am migrating the InfrastructureModels ecosystem away from Memento.jl.
See lanl-ansi/InfrastructureModels.jl#99
PMD made this change a number of years ago. Your current design has a number of unforeseen consequences.
There are two main issues. The first is that this function mutates global state. If someone changes the logger after PMD, this function will erase their changes back to the global state before PMD.
Summary: this is a pretty significant modernization of PMD and will make future fixes easier. All tests pass on this branch.